feat: drop dependency on gh #1000
Conversation
JoshuaKGoldberg
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
+ Coverage 94.18% 94.21% +0.03%
==========================================
Files 97 97
Lines 5620 5667 +47
Branches 457 462 +5
==========================================
+ Hits 5293 5339 +46
- Misses 326 327 +1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
For retrieving a user auth token, JoshuaKGoldberg/prune-github-notifications#167 also tracks creating a standalone package. |
JoshuaKGoldberg
added
the
status: waiting for author
|
The not having a better way than |
| } | ||
| } catch (error) { | ||
| throw new Error("Failed to create new repository on GitHub.", { | ||
| cause: error, |
There was a problem hiding this comment.
Not strictly necessary for this PR, but the bad error was bugging me when I was testing out permissions. 😄
|
🎉 This is included in version v1.71.0 🎉 The release is available on: Cheers! 📦🚀 |
JoshuaKGoldberg
removed
the
status: waiting for author
PR Checklist
status: accepting prsOverview
Replaces the end-user dependency on
gh(the GitHub CLI) with more manual Octokit calls. It's a bit less convenient this way but is more type-safe and means users don't need to have some random GitHub utility installed to use the template.Update December 2023: this works but I don't like how the user has to either have
ghlogged in or use aprocess.env.GH_TOKEN... I'd like to find the time to look into alternatives to log the user in.Update August 2024: I don't want to procrastinate any more. This PR doesn't make things worse. So as long as error messages explicitly tell people to either log in with
ghor setprocess.env.GH_TOKEN, this is fine.