Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Use get-github-auth-token instead of $(gh auth token) #1532

Closed
2 tasks done
JoshuaKGoldberg opened this issue May 26, 2024 · 1 comment · Fixed by #1533
Closed
2 tasks done

🚀 Feature: Use get-github-auth-token instead of $(gh auth token) #1532

JoshuaKGoldberg opened this issue May 26, 2024 · 1 comment · Fixed by #1533
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

Overview

I just published https://github.com/JoshuaKGoldberg/get-github-auth-token, which is a small utility that attempts to find a GitHub auth token from the following places, in order:

  1. process.env.GH_TOKEN
  2. Executing gh auth token as a child process

Let's use that as the underlying way to get GitHub auth tokens. This can work as a precursor to #667 -> #1000.

Additional Info

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels May 26, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this May 26, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🚀 Feature: <short description of the feature> 🚀 Feature: Use get-github-auth-token instead of $(gh auth token) May 26, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue May 26, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue May 26, 2024
@JoshuaKGoldberg
feat: use get-github-auth-token instead of gh auth token (#1533)
9eef9f6 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1532
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Swaps out `gh auth token` with `await getGitHubAuthToken()`. Doesn't
fully remove the dependency on `gh`.

💖
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.60.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use get-github-auth-token instead of gh auth token JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg