chore: verify changes on allowedFiles according to the template #1048

Aslemammad · 2023-11-21T15:52:08Z

script/migrate-test-e2e.js

PR Checklist

Addresses an existing open issue: fixes 🧪 Testing: End-to-end hydrate tests should still verify expected changes to files are correct #546
That issue was marked as status: accepting prs
Steps in CONTRIBUTING.md were taken

Overview

We track the changes using createRootFiles and we watch the changes files based on the function result.

codecov · 2023-11-21T19:42:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f8e90f) 94.29% compared to head (838340b) 94.27%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   94.29%   94.27%   -0.02%     
==========================================
  Files          97       97              
  Lines        5626     5626              
  Branches      455      455              
==========================================
- Hits         5305     5304       -1     
- Misses        320      321       +1     
  Partials        1        1

Flag	Coverage Δ
create	`70.22% <ø> (ø)`
initialize	`42.16% <ø> (ø)`
migrate	`69.60% <ø> (-0.08%)`	⬇️
unit	`72.32% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JoshuaKGoldberg

A good start, thanks for looking into this! I think the general strategy is mostly implemented well... but the strategy itself I think is going to need to be reworked. What do you think?

script/migrate-test-e2e.js

JoshuaKGoldberg · 2023-11-21T19:47:29Z

Btw, looks like there are some CI failures. You'll want to fix them up. .github/DEVELOPMENT.md should be helpful in pointing out the tools. If anything's unclear let me know!

JoshuaKGoldberg · 2023-11-21T19:55:01Z

Whoops, I pushed to the wrong branch working on another PR - sorry about that :)

JoshuaKGoldberg

Progress! 🚀

script/migrate-test-e2e.js

script/verify-changes.test.ts

script/__snapshots__/verify-changes.test.ts.snap

JoshuaKGoldberg

🙌 this is looking great, nice work! I like the snapshot approach. And it's already found a bunch of discrepancies - filed inline to fix separately. Yay!

Requesting changes largely because the script never finishes running, and filtering out a few specific things from the snapshots. I left a few questions inline too.

script/__snapshots__/verify-changes.test.ts.snap

script/verify-changes.test.ts

script/migrate-test-e2e.js

…ad/create-typescript-app into fix/verify-changes-in-hydration

Aslemammad · 2023-12-27T04:51:58Z

@JoshuaKGoldberg Let me know if this is ready for a merge.

JoshuaKGoldberg

Wonderful, thanks so much for all your hard work on this PR @Aslemammad! I think it looks great and will be very helpful keeping the last few files aligned to the templates as time goes on.

I'll apply a couple touchups myself for linking to upstream bugs & adding back bin/index.js. But no more blockers. Yay!

script/migrate-test-e2e.js

JoshuaKGoldberg · 2023-12-30T06:49:58Z

script/__snapshots__/migrate-test-e2e.js.snap

+-	"packageManager": "pnpm@8.12.1",
+	"packageManager": "pnpm@8.7.0",


Heh, and in CI:

2023-12-30T06:48:46.9914884Z }, 2023-12-30T06:48:46.9915527Z - - "packageManager": "pnpm@8.12.1", 2023-12-30T06:48:46.9916260Z + - "packageManager": "pnpm@8.13.1", 2023-12-30T06:48:46.9916878Z + "packageManager": "pnpm@8.7.0",

This'll probably start failing as soon as a new pnpm version is out. Lovely. That can be a followup.

Aslemammad · 2023-12-30T06:50:21Z

I'll apply a couple touchups myself for linking to upstream bugs & adding back bin/index.js. But no more blockers. Yay!

Thank you so much, happy to see it finally being merged!

script/migrate-test-e2e.js

JoshuaKGoldberg · 2023-12-30T09:13:09Z

❌ codecov/project — 94.27% (-0.02%) compared to 2f8e90f

...very amusing.

JoshuaKGoldberg · 2023-12-30T09:13:40Z

Oh, and: renaming the PR title to chore: because this is just an internal-only improvement. It doesn't impact end-users.

JoshuaKGoldberg · 2023-12-30T09:14:24Z

@all-contributors please add @Aslemammad for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

allcontributors · 2023-12-30T09:14:34Z

@JoshuaKGoldberg

I've put up a pull request to add @Aslemammad! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@Aslemammad

Adds @Aslemammad as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#1048 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

github-actions · 2023-12-30T12:47:54Z

🎉 This is included in version v1.50.2 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg requested changes Nov 21, 2023

View reviewed changes

script/migrate-test-e2e.js Outdated Show resolved Hide resolved

JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Nov 21, 2023

JoshuaKGoldberg force-pushed the fix/verify-changes-in-hydration branch from 21a6c06 to b7878d9 Compare November 21, 2023 19:54

Aslemammad added 4 commits November 27, 2023 09:38

add vitest test file

255423e

add vitest test file

094710a

add vitest test file

cc7d20f

add vitest test file

8b92ae4

Aslemammad force-pushed the fix/verify-changes-in-hydration branch from b7878d9 to 8b92ae4 Compare November 27, 2023 06:43

JoshuaKGoldberg requested changes Nov 28, 2023

View reviewed changes

script/migrate-test-e2e.js Outdated Show resolved Hide resolved

script/verify-changes.test.ts Outdated Show resolved Hide resolved

Aslemammad and others added 3 commits December 9, 2023 06:30

small update

acf2aeb

update snapshots

b52a6a3

Merge branch 'main' into fix/verify-changes-in-hydration

55bdaef

JoshuaKGoldberg mentioned this pull request Dec 11, 2023

🛠 Tooling: Repository uses the wrong emoji in .all-contributorsrc #1086

Closed

3 tasks

JoshuaKGoldberg reviewed Dec 11, 2023

View reviewed changes

script/__snapshots__/verify-changes.test.ts.snap Outdated Show resolved Hide resolved

JoshuaKGoldberg mentioned this pull request Dec 11, 2023

🛠 Tooling: Repository might not need to pnpm build || true in lint-knip.yml #1087

Closed

3 tasks

JoshuaKGoldberg reviewed Dec 11, 2023

View reviewed changes

script/__snapshots__/verify-changes.test.ts.snap Outdated Show resolved Hide resolved

JoshuaKGoldberg mentioned this pull request Dec 11, 2023

🛠 Tooling: Repository badges are out-of-date compared to the template #1088

Closed

3 tasks

JoshuaKGoldberg reviewed Dec 11, 2023

View reviewed changes

script/__snapshots__/verify-changes.test.ts.snap Outdated Show resolved Hide resolved

This was referenced Dec 11, 2023

🛠 Tooling: Unnecessary --report-unused-disable-directives in templating #1089

Closed

🛠 Tooling: Unnecessary commitType: docs in .all-contributorsrc #1090

Open

🛠 Tooling: Migration end-to-end test should use --guide and --guide-title #1091

Closed

JoshuaKGoldberg requested changes Dec 11, 2023

View reviewed changes

jaas666 mentioned this pull request Dec 11, 2023

chore: cleanup --report-unused-disable-directives #1093

Merged

3 tasks

Aslemammad added 4 commits December 13, 2023 23:38

exit vitest

7b2a432

Merge branch 'fix/verify-changes-in-hydration' of github.com:Aslemamm…

dd944f5

…ad/create-typescript-app into fix/verify-changes-in-hydration

feat: -u

7a3967f

fix: author

fcb2e6f

JoshuaKGoldberg approved these changes Dec 30, 2023

View reviewed changes

script/migrate-test-e2e.js Show resolved Hide resolved

JoshuaKGoldberg added 3 commits December 30, 2023 01:28

add bin/index.js to filesExpectedToBeChanged

3efcf07

Set --author manually from packageData

caf4793

Updated migrate-test-e2e.js.snap for new author

25a103d

JoshuaKGoldberg reviewed Dec 30, 2023

View reviewed changes

JoshuaKGoldberg added 2 commits December 30, 2023 01:50

pnpm@8.13.1

2d7a66b

Merge branch 'main' into fix/verify-changes-in-hydration

c5abcd5

JoshuaKGoldberg mentioned this pull request Dec 30, 2023

🛠 Tooling: End-to-end migration test lint takes a long time on coverage-migrate/ files #1131

Closed

3 tasks

Merge branch 'main'

158a9cf

JoshuaKGoldberg mentioned this pull request Dec 30, 2023

🛠 Tooling: End-to-end migration test should run with --bin #1133

Closed

3 tasks

JoshuaKGoldberg reviewed Dec 30, 2023

View reviewed changes

script/migrate-test-e2e.js Outdated Show resolved Hide resolved

JoshuaKGoldberg added 2 commits December 30, 2023 02:53

Merge branch 'main'

44e4f2a

Update snapshot

b35f4e6

JoshuaKGoldberg mentioned this pull request Dec 30, 2023

🛠 Tooling: End-to-end migration test should run with --guide #1135

Closed

3 tasks

JoshuaKGoldberg added 3 commits December 30, 2023 03:51

Merge branch 'main'

c938399

Update script/migrate-test-e2e.js

ac3c2ac

Update test snapshot

838340b

JoshuaKGoldberg changed the title ~~feat: verify changes on allowedFiles according to the template~~ chore: verify changes on allowedFiles according to the template Dec 30, 2023

JoshuaKGoldberg merged commit 7390c17 into JoshuaKGoldberg:main Dec 30, 2023
17 of 18 checks passed

allcontributors bot mentioned this pull request Dec 30, 2023

docs: add aslemammad as a contributor for code #1139

Merged

This was referenced Dec 30, 2023

📝 Documentation: Explain how to work with end-to-end migration test snapshots #1141

Closed

🛠 Tooling: Filter out noisy areas from end-to-end migration test snapshots #1142

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: verify changes on allowedFiles according to the template #1048

chore: verify changes on allowedFiles according to the template #1048

Aslemammad commented Nov 21, 2023

codecov bot commented Nov 21, 2023 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg commented Nov 21, 2023 •

edited

Loading

JoshuaKGoldberg commented Nov 21, 2023

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

Aslemammad commented Dec 27, 2023

JoshuaKGoldberg left a comment

JoshuaKGoldberg Dec 30, 2023

Aslemammad commented Dec 30, 2023

JoshuaKGoldberg commented Dec 30, 2023

JoshuaKGoldberg commented Dec 30, 2023

JoshuaKGoldberg commented Dec 30, 2023

allcontributors bot commented Dec 30, 2023

github-actions bot commented Dec 30, 2023

		- "packageManager": "pnpm@8.12.1",
		+ "packageManager": "pnpm@8.7.0",

chore: verify changes on allowedFiles according to the template #1048

chore: verify changes on allowedFiles according to the template #1048

Conversation

Aslemammad commented Nov 21, 2023

PR Checklist

Overview

codecov bot commented Nov 21, 2023 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg commented Nov 21, 2023 • edited Loading

JoshuaKGoldberg commented Nov 21, 2023

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Aslemammad commented Dec 27, 2023

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg Dec 30, 2023

Choose a reason for hiding this comment

Aslemammad commented Dec 30, 2023

JoshuaKGoldberg commented Dec 30, 2023

JoshuaKGoldberg commented Dec 30, 2023

JoshuaKGoldberg commented Dec 30, 2023

allcontributors bot commented Dec 30, 2023

github-actions bot commented Dec 30, 2023

codecov bot commented Nov 21, 2023 •

edited

Loading

JoshuaKGoldberg commented Nov 21, 2023 •

edited

Loading