Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't suggest --skip options in rerun if --offline #1308

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Applies a couple of bits of good normalization to printed options:

  • Removes the manual --mode so it doesn't get duplicated
  • Sets the relevant skip* options to undefined if options.offline is enabled

Also adds some unit tests around partial options, as that was missing before.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 373e1b7 into main Feb 15, 2024
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the rerun-offline-no-skip branch February 15, 2024 16:05
Copy link

🎉 This is included in version v1.57.6 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant