Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Re-run command suggestion includes unnecessary --skip-all-contributors-api and --skip-github-api if --offline #1128

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 29, 2023 · 1 comment · Fixed by #1308
Closed
3 tasks done

🐛 Bug: Re-run command suggestion includes unnecessary --skip-all-contributors-api and --skip-github-api if --offline #1128

JoshuaKGoldberg opened this issue Dec 29, 2023 · 1 comment · Fixed by #1308
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Providing --offline to npx create-typescript-app implies --skip-all-contributors-api true --skip-github-api true. Re-run suggestions after you're done shouldn't include those two skip commands if --offline was provided.

Actual

Alas, the rerun suggestion does include them:

npx create-typescript-app --mode create --offline
┌  ✨ Welcome to create-typescript-app 1.50.0! ✨
│
│  ⚠️ This template is early stage, opinionated, and not endorsed by the TypeScript team. ⚠️
│  ⚠️ If any tooling it sets displeases you, you can always remove that portion manually. ⚠️
│
■  What organization or user will the repository be under?
│
│
●  Tip: to run again with the same input values, use: npx create-typescript-app --mode undefined --offline true --skip-all-contributors-api true --skip-github-api true
│
└  Operation cancelled. Exiting - maybe another time? 👋

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 29, 2023
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 15, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Feb 15, 2024
@JoshuaKGoldberg
fix: don't suggest --skip options in rerun if --offline (#1308)
373e1b7 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1128; #1130
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Applies a couple of bits of good normalization to printed options:

* Removes the manual `--mode` so it doesn't get duplicated
* Sets the relevant `skip*` options to `undefined` if `options.offline`
is enabled

Also adds some unit tests around partial options, as that was missing
before.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.57.6 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't suggest --skip options in rerun if --offline JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg