Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove .all-contributorsrc from .prettierignore #806

Merged
merged 2 commits into from
Sep 5, 2023
Merged

fix: remove .all-contributorsrc from .prettierignore #806

merged 2 commits into from
Sep 5, 2023

Conversation

conrmahr
Copy link
Contributor

@conrmahr conrmahr commented Sep 5, 2023

PR Checklist

Overview

This PR is a fix for the all-contributors/cli#347 issue now being resolved. Ignoring the .all-contributorsrc file in the .prettierignore file is unnecessary. 😎

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 5, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 perfect, thanks!

@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #806 (4563c8c) into main (8f974a2) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   91.61%   91.60%   -0.01%     
==========================================
  Files          84       84              
  Lines        4161     4158       -3     
  Branches      248      248              
==========================================
- Hits         3812     3809       -3     
  Misses        349      349
Flag Coverage Δ
create 72.01% <ø> (-0.03%) ⬇️
initialize 34.03% <ø> (+0.02%) ⬆️
migrate 73.33% <ø> (-0.02%) ⬇️
unit 47.66% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/writing/creation/rootFiles.ts 96.95% <ø> (-0.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

JoshuaKGoldberg
JoshuaKGoldberg requested changes Sep 5, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oop, looks like there's a formatting error - can you fix it @conrmahr?

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Sep 5, 2023
@conrmahr
Copy link
Contributor Author

conrmahr commented Sep 5, 2023

✅ pnpm format --list-different - Doesn't error out now locally.
✅ pnpn test - All tests passed.

Hope that fixes it. 🙏

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 5, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author Needs an action taken by the original poster label Sep 5, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit 8dbde91 into JoshuaKGoldberg:main Sep 5, 2023
15 of 16 checks passed
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @conrmahr for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Sep 5, 2023
Closed
@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @conrmahr! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🎉 This is included in version v1.29.34 🎉

The release is available on:

Cheers! 📦🚀

This was referenced Sep 19, 2023
Closed
Merged
Open
JoshuaKGoldberg added a commit that referenced this pull request Sep 19, 2023
@JoshuaKGoldberg
fix: add .allcontributorsrc back to .prettierignore (#838)
cc8a98d 
## PR Checklist

- [x] Addresses an existing open issue: fixes #837
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

😢. #806 was perfect. But the tooling appears to not be working properly.

fyi @conrmahr - maybe we can try again in a few months?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Remove .all-contributorsrc from .prettierignore
2 participants
@conrmahr @JoshuaKGoldberg