Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Remove .all-contributorsrc from .prettierignore #801

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 5, 2023 · 1 comment · Fixed by #806
Closed
3 tasks done

🛠 Tooling: Remove .all-contributorsrc from .prettierignore #801

JoshuaKGoldberg opened this issue Sep 5, 2023 · 1 comment · Fixed by #806
Labels
area: tooling Managing the repository's maintenance good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

create-typescript-app/.prettierignore

Lines 5 to 6 in cdcf22b

# See https://github.com/all-contributors/cli/issues/347
.all-contributorsrc

all-contributors/cli#347 is now resolved. So we should be able to remove these two lines from .prettierignore. Yay!

Additional Info

Note that the template for .prettierignore will also need to be updated:

create-typescript-app/src/steps/writing/creation/rootFiles.ts

Lines 50 to 57 in f4f0233

".prettierignore": formatIgnoreFile([
...(options.excludeTests ? [] : ["coverage/"]),
"lib/",
"pnpm-lock.yaml",
"",
"# See https://github.com/all-contributors/cli/issues/347",
".all-contributorsrc",
]),

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Sep 5, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 5, 2023
@conrmahr conrmahr mentioned this issue Sep 5, 2023
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this issue Sep 5, 2023
@conrmahr
fix: remove .all-contributorsrc from .prettierignore (#806)
8dbde91 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #801
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->
This PR is a fix for the all-contributors/cli#347 issue now being
resolved. Ignoring the `.all-contributorsrc` file in the
`.prettierignore` file is unnecessary. 😎
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🎉 This is included in version v1.29.34 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

fix: remove .all-contributorsrc from .prettierignore conrmahr/create-typescript-app
1 participant
@JoshuaKGoldberg