Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Create a common component for code tags #291

Closed
3 tasks done
JoshuaKGoldberg opened this issue Apr 25, 2024 · 1 comment · Fixed by #413
Closed
3 tasks done

🛠 Tooling: Create a common component for code tags #291

JoshuaKGoldberg opened this issue Apr 25, 2024 · 1 comment · Fixed by #413
Labels
area: tooling Managing the repository's maintenance 🛠️ good first issue Good for newcomers, please hop on! 🙌 status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

This comment exists in doc-content.tsx:

// TODO: create a component for code tag so that the styles are automatically applied

It's in reference to there being a lot of <code css={usageStyles.code}> tags in the page. Agreed, this would be a nice opportunity to refactor a bit to extract out a shared component for code.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 good first issue Good for newcomers, please hop on! 🙌 area: tooling Managing the repository's maintenance 🛠️ labels Apr 25, 2024
@Princeyadav05 Princeyadav05 mentioned this issue Jun 9, 2024
Merged
3 tasks
@Princeyadav05
Copy link

@JoshuaKGoldberg has done the required changes and ran the site locally, everything worked fine.
Let me know if anything needs to be changed here.

JoshuaKGoldberg added a commit that referenced this issue Jun 11, 2024
@JoshuaKGoldberg
feat: created a new code tag to reduce repeated code (#413)
75c6974 
<!-- 👋 Hi, thanks for sending a PR to emoji-blast! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #291 
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/emoji-blast/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/emoji-blast/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

1. Added a new code tag in components
2. Replaced the code tag in doc-content.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance 🛠️ good first issue Good for newcomers, please hop on! 🙌 status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: created a new code tag to reduce repeated code Princeyadav05/emoji-blast
2 participants
@JoshuaKGoldberg @Princeyadav05