Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: created a new code tag to reduce repeated code #413

Conversation

Princeyadav05
Copy link

PR Checklist

Overview

  1. Added a new code tag in components
  2. Replaced the code tag in doc-content.tsx

Copy link

changeset-bot bot commented Jun 9, 2024

⚠️ No Changeset found

Latest commit: 04f4896

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emoji-blast ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 5:06am

@@ -0,0 +1,10 @@
import * as usageStyles from "../usage-container/styles";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: in theory I'd normally suggest that styles not be shared across components like this. It can get hard to detangle/refactor styles en masse. But, this pattern is already done, and I'm redoing the site in #405 -> #406 anyway.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks - much appreciated! 🙌

@JoshuaKGoldberg JoshuaKGoldberg merged commit 75c6974 into JoshuaKGoldberg:main Jun 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Create a common component for code tags
2 participants