[Finishes #158656875] Improve Code Quality #24

JoshuaOndieki · 2018-06-27T21:03:30Z

What does this PR do?*
Improves the code quality as per the reviews on #3

coveralls · 2018-06-27T23:13:01Z

Pull Request Test Coverage Report for Build 100

123 of 130 (94.62%) changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 95.327%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
ridemyway/resources.py	9	11	81.82%
ridemyway/controllers/ride_request_controller.py	7	12	58.33%

… operation

JoshuaOndieki added 7 commits June 27, 2018 23:58

[Closes #14] Missing docstring

a05b9e3

[Closes #19] Superfluous parens

c6624c2

[Closes #22] Wrong hanging indentation

bc0081f

[Closes #23] Group imports

835d053

[Closes #21] Confirm to naming style

7884568

[Closes #18, Closes #20] Avoid catching too general exception Exception

1013071

[Closes #15] Use self on methods

4a2aac1

Repository owner deleted a comment Jun 27, 2018

JoshuaOndieki added 4 commits June 28, 2018 02:33

(Resolves binary-op-exception) Catch exceptions as a result of binary…

cec14cd

… operation

Avoid using len(SEQUENCE) as condition - use if SEQUENCE instead

b37d994

Resolve unused imports

b6ee2e1

[Closes

9f1f5d9

Repository owner deleted a comment Jun 28, 2018

Add module to generate responses

e2e4877

Repository owner deleted a comment Jun 28, 2018

JoshuaOndieki merged commit d8808c1 into develop Jun 28, 2018