Skip to content

/ genius

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genius_lyrics retrieves singer for each verse as lyrics #4

Closed
dgruenew opened this issue Feb 27, 2018 · 2 comments
Closed

genius_lyrics retrieves singer for each verse as lyrics #4

dgruenew opened this issue Feb 27, 2018 · 2 comments
Labels
bug

Comments

@dgruenew
Copy link

@dgruenew dgruenew commented Feb 27, 2018

Just tried this for the following:

raw_df <- geniusR::genius_lyrics(artist = "Pink Floyd",
                                 song = "Comfortably Numb",
                                 info = "all")

Which gives the singer "Roger Waters" as the very first lyric. "David Gilmour" is recorded as well for line 14.

(very cool package by the way!)
@JosiahParry
Copy link
Owner

@JosiahParry JosiahParry commented Feb 28, 2018

Hm. Interesting. I thought I solved the bracket issue! I'll be sure to give this a look. Thank you!
@JosiahParry JosiahParry added the bug label Feb 28, 2018
eoppe1022 added a commit to eoppe1022/geniusR that referenced this issue Apr 28, 2018
@eoppe1022
Update prep_info.R JosiahParry#4 (changes to redundant regex)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
2f8d158 
Regex to deal with +, /, :, $, é, and ö

Deleted `" /" = ""` and edited ` \\+ = ""` to `\\+` = " "` from last commit.
@JosiahParry JosiahParry mentioned this issue Dec 14, 2018
Merged
@JosiahParry JosiahParry mentioned this issue Dec 24, 2018
Merged
@JosiahParry
Copy link
Owner

@JosiahParry JosiahParry commented Dec 24, 2018

fixed in pr #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@JosiahParry @dgruenew
You can’t perform that action at this time.