Fixes #7 Deprecated Incrementer check due to too many false positives

JossWhittle · May 6, 2014 · e1b06db · e1b06db
1 parent 1983b2d
commit e1b06db
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/flint/Checks.cpp b/flint/Checks.cpp
@@ -903,6 +903,9 @@ namespace flint {
 		}
 	};
 
+	// ******************************************
+	// Deprecated due to too many false positives
+	// ******************************************
 	/**
 	* Check for postfix incrementers
 	*
@@ -912,7 +915,7 @@ namespace flint {
 	*		The path to the file currently being linted
 	* @param tokens
 	*		The token list for the file
-	*/
+	
 	void checkIncrementers(ErrorFile &errors, const string &path, const vector<Token> &tokens) {
 
 		const vector<TokenType> iteratorPlus = {
@@ -931,6 +934,7 @@ namespace flint {
 			}
 		}
 	};
+	*/
 
 	/**
 	* Balance of #if(#ifdef, #ifndef)/#endif.

diff --git a/flint/Checks.hpp b/flint/Checks.hpp
@@ -13,7 +13,9 @@ namespace flint {
 #define X(func)																\
 	void check##func(ErrorFile &errors, const string &path, const vector<Token> &tokens)
 
-	X(Incrementers);
+	// Deprecated due to too many false positives
+	//X(Incrementers);
+
 	X(DefinedNames);
 	X(CatchByReference);
 	X(BlacklistedSequences);

diff --git a/flint/Main.cpp b/flint/Main.cpp
@@ -101,7 +101,8 @@ void checkEntry(ErrorReport &errors, const string &path, uint depth = 0) {
 		// Checks which note Advice
 		if (Options.LEVEL >= Lint::ADVICE) {
 
-			checkIncrementers(errorFile, path, tokens);
+			// Deprecated due to too many false positives
+			//checkIncrementers(errorFile, path, tokens);
 
 			if (!Options.CMODE) {
 				checkUpcaseNull(errorFile, path, tokens);