-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltips to player controls #1015
Merged
drillprop
merged 6 commits into
Joystream:video-player-update
from
drillprop:player-tooltip
Jul 22, 2021
Merged
Add tooltips to player controls #1015
drillprop
merged 6 commits into
Joystream:video-player-update
from
drillprop:player-tooltip
Jul 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
656d1d8
to
bebb151
Compare
7db212e
to
c8b21e7
Compare
bebb151
to
5b0f72f
Compare
c8b21e7
to
95f4567
Compare
rafalpawlow
reviewed
Jul 21, 2021
rafalpawlow
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just added one small change.
Converted to a draft. |
kdembler
approved these changes
Jul 22, 2021
e904c0f
to
ad883c8
Compare
drillprop
added a commit
that referenced
this pull request
Jul 22, 2021
* add VideoControlWithTooltip * refactor * use css for tooltips * lint fix * transition fix * lint
drillprop
added a commit
that referenced
this pull request
Jul 23, 2021
* add VideoControlWithTooltip * refactor * use css for tooltips * lint fix * transition fix * lint
drillprop
added a commit
that referenced
this pull request
Jul 26, 2021
* add VideoControlWithTooltip * refactor * use css for tooltips * lint fix * transition fix * lint
kdembler
pushed a commit
that referenced
this pull request
Jul 28, 2021
* add VideoControlWithTooltip * refactor * use css for tooltips * lint fix * transition fix * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #937
Figma: https://www.figma.com/file/TGUpBXgXf9ceMvHbRB5BIx/Joystream-Atlas?node-id=9977%3A263879
https://www.figma.com/file/TGUpBXgXf9ceMvHbRB5BIx/Joystream-Atlas?node-id=9164%3A0
I will tackle the timeline tooltip in another PR