Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltips to player controls #1015

Merged
merged 6 commits into from
Jul 22, 2021
Merged

Add tooltips to player controls #1015

merged 6 commits into from
Jul 22, 2021

Conversation

drillprop
Copy link
Contributor

@drillprop drillprop commented Jul 20, 2021 •
edited

@drillprop drillprop linked an issue Jul 21, 2021 that may be closed by this pull request
Add tooltip to player controls #937
Closed
rafalpawlow
rafalpawlow approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@rafalpawlow rafalpawlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just added one small change.

@drillprop drillprop marked this pull request as draft July 21, 2021 09:48
@drillprop
Copy link
Contributor Author

Converted to a draft.
Had a quick chat with designer and I will need to change animations a bit.
Also, I don't like how I've done that in the end. There is too much wrappers here. Will try to implement "css only" solution

@drillprop drillprop marked this pull request as ready for review July 21, 2021 12:16
@drillprop drillprop merged commit be72982 into Joystream:video-player-update Jul 22, 2021
drillprop added a commit that referenced this pull request Jul 22, 2021
@drillprop
Add tooltips to player controls (#1015)
7b23ef0 
* add VideoControlWithTooltip

* refactor

* use css for tooltips

* lint fix

* transition fix

* lint
drillprop added a commit that referenced this pull request Jul 23, 2021
@drillprop
Add tooltips to player controls (#1015)
3db20bd 
* add VideoControlWithTooltip

* refactor

* use css for tooltips

* lint fix

* transition fix

* lint
drillprop added a commit that referenced this pull request Jul 26, 2021
@drillprop
Add tooltips to player controls (#1015)
5090893 
* add VideoControlWithTooltip

* refactor

* use css for tooltips

* lint fix

* transition fix

* lint
kdembler pushed a commit that referenced this pull request Jul 28, 2021
@drillprop @kdembler
Add tooltips to player controls (#1015)
54e9995 
* add VideoControlWithTooltip

* refactor

* use css for tooltips

* lint fix

* transition fix

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdembler kdembler kdembler approved these changes

@rafalpawlow rafalpawlow rafalpawlow approved these changes

Assignees
No one assigned
Labels
status:approved status:needs rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tooltip to player controls
3 participants
@drillprop @kdembler @rafalpawlow