Staking

Remove duplicate minting trait bound

New commit hash

…rations

Is required to avoid caller burden of cleaning up imbalance parameters in failure outcome of add_application.

Rome version of hiring module

Added activation and deactivation of relationships

…eam modules

rustfmt + update dependency

- fix redundant field names in struct initialization
- change assert!(false) to panic! with comments

- fix using `clone` on a `Copy` type
- fix match on a boolean expression
- fix passing small enum by reference
- fix typos

- rustfmt
- fix doc comments

- upgrade to directory
- introduce application, opening, staking_policy submodules
- copy related code to the new modules
- implement several macro’s as generic functions

- move application and opening entities to related modules
- move staking_policy methods to staking_policy module

- fix very complex type warning

- altered add_application
- altered deactive_application

Cover main hiring workflow:
1. add_opening
2. add_application
3. begin_review
4. fill_opening

- remove comment
- add check for application is not crowded out
- add more comments to checks

- add ensure_can_add_application basic check
- add more comments

- add wiki ling to smoke-test concept

- mark ‘macroes’ mod with #[macro_use]
- remove all #[macro_export]

- move out opening checks from lib.rs to opening.rs
- move out opening construction to opening.rs (as ::new() constructor)
- delete obsolete macro ensure_amount_valid_in_opt_staking_policy

- improve readability of call_and_assert()
- check content asserts inside call_and_assert()
- revert error handling back to assert!

- add tests for begin_accepting_applications
- add test for add_opening with Exact block activation
- commented empty tests for future use in mod.rs

- move out code from lib.rs to opening.rs
- mark some pub methods as crate-only

- refactor begin_review()
- move some code from application.rs to opening.rs

- clean comments in tests/mod.rs
- add future test TODOs

- remove some comments
- reorder usings
- apply rustfmt

- introduce assert_opening_content() method

travis CI

Description:
- In add_application()  -  Opening::OpeningStage::Active{applications_added} is not updated with newly created ApplicationId, which leads to invalid 'application-crowded-out' logic.

Solution:
- add new application_id to the opening active stage

- add tests for add_application()
- add tests for ensure_can_add_application()
- fill ‘not covered’ section for both test packs

- add ‘crowded out application’ tests
- application content tests
- comment ‘won’t do’ checks for stakes

Description:
- Invalid opening state after adding_application - unstaking counter update dismissed in case of the crowded out application

Solution:
- Load opening state again after try_to_initiate_application_deactivation() to get updated counter data

- add checks for opening content after add_application()

Add tests for:
- opening status
- unstaking periods
- application status

New tests:
- application content checks
- opening content checks

…mprovement(1-2)

Hiring module improvement (combined PR iterations 1-2)

- introduce UnstakedResult enum with unstake result entries
- add UnstakedResult as return value of unstaked() - shouldn’t break upstream code
- cover unstake() with tests
- add minor code to the application entity for future unstake refactoring

- introduce new AddOpeningError enum entry - ApplicationRationingZeroMaxApplicants
- add check to ensure_can_add_opening()
- cover new logic with test

…_rationioning_policy_bug

Fix bug with zero 'max_active_applicants' parameter

- introduce new AddOpeningError enum entry - ApplicationRationingZeroMaxApplicants
- add check to ensure_can_add_opening()
- cover new logic with test

- add tests for parameter checks
- add test for simple successful call

- add opening content test
- add application content test on failed cancel opening

- remove RemoveOpeningError due obsolete remove_opening() feature

- add tests regarding opening state

Test pack #1 for hiring module.