disable and clear account indices #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
obsolete now, done in #28 |
shamil-gadelshin
pushed a commit
to shamil-gadelshin/joystream-network
that referenced
this pull request
Mar 9, 2020
…nd_mock_branch Combined test and mock branch
mnaamani
pushed a commit
to mnaamani/joystream
that referenced
this pull request
Mar 20, 2020
rename Proposal to RuntimeUpgradeProposal
Lezek123
pushed a commit
to Lezek123/substrate-runtime-joystream
that referenced
this pull request
May 21, 2020
* Remove extra subjects from app-explorer * Use bs58 addresses * Base upgrades subject -> onChange * app-storage & app-explorer works * Remove useless placeholder * Progres... * Rename Submission -> Selection * Baby steps... things display now... * setState operational * Explicit onChange * Work around eslint issues (!!!) * @flow fixes * Small styling updates * Small app content styling updates * Simplify
mnaamani
pushed a commit
to mnaamani/joystream
that referenced
this pull request
Jun 19, 2020
…ider-role-integration Finish role signup process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear indices, and prevent new accounts from generating an AccountIndex.
#2 for context
The base issue is in our testnet we allow accounts to go to zero balance and not get reaped, because we configured existential deposit to be zero. Without this change account index reuse will occur and if anyone is relying on the account index in place of full account id (mainly in transfers) they may be unpleasantly surprised.