Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JoystreamJS: Generate commitment from arbitrary bytes source #4584

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

thesan
Copy link
Member

@thesan thesan commented Jan 30, 2023

This is needed by Joystream/pioneer#4095 becausefs is not available in the browser. Instead the payload file is provided to the browser as a File.

@vercel
Copy link

vercel bot commented Jan 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
pioneer-testnet ⬜️ Ignored (Inspect) Jan 30, 2023 at 10:31AM (UTC)

@thesan thesan force-pushed the joystream-js-arbitrary-bin-source branch from 8b2434b to ccbfd21 Compare January 30, 2023 10:31
@thesan thesan changed the base branch from ephesus to master September 27, 2023 08:31
@thesan thesan changed the base branch from master to nara September 27, 2023 08:31
@thesan thesan changed the base branch from nara to master September 27, 2023 08:31
@thesan
Copy link
Member Author

thesan commented Sep 27, 2023

@zeeshanakram3 BTW this is needed in Pioneer here

Copy link
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaamani mnaamani merged commit bcddf45 into Joystream:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants