Ephesus merge mainnet liberated

[ignazio-bovo]

merge mainnet-liberated into ephesus #4556

Main points

• the runtime & node version should be correct, but the QN / cli versioning should be reviewed
• I left a comment for the update_curator_group_permissions call which I was not sure where it should be enabled or not update: I left the proposal disabled as we don't have integration tests for this yet
• pallet_membership::create_member relies on root as it was used for founding members. Hence it is not used anymore and I have removed the respective tests from the full scenario
• There are still outstading PR targeting ephesus:
  • Fix channel payouts mappings and add missing tests #4594
  • Ephesus: output blake3 hash of channel payload file when using CLI #4575
  • Ephesus channel payouts proposal cli Commands #4441
  • JoystreamJS: Generate commitment from arbitrary bytes source #4584
  • Joystream js app action commitment helper #4586
  • Ephesus runtime upgrade ci #4569 (I will retarget this after this PR has been merged)
  • Ephesus governance opt out int tests #4598 (I will retarget this after this PR has been merged)

┆Issue is synchronized with this Asana task by Unito

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
pioneer-testnet	⬜️ Ignored (Inspect)			Feb 7, 2023 at 10:53AM (UTC)

[bedeho]

Who else should review this?

[mnaamani]

The two flows a failing consistently in the network integration tests:

channel payouts proposal: Failed
group budget: Failed

[ignazio-bovo]

The two flows a failing consistently in the network integration tests:

channel payouts proposal: Failed
group budget: Failed

In the channelclaim-* fixtures there where Council budget checks. They where concurrent to the budget update logic run at each new block, that's why they where failing. Budget checks would have been nice, but implementing them is time consuming.

The other error was due to inviting members being run concurrently to the upgrade Membership Group budget fixture (so you had 2 concurrent budget updates)

[mnaamani]

I think we can drop this entierly. It uses sudo. We forgot about it in mainnet-liberated branch

[mnaamani]

In the channelclaim-* fixtures there where Council budget checks. They where concurrent to the budget update logic run at each new block, that's why they where failing. Budget checks would have been nice, but implementing them is time consuming.

I would have assumed these were working before. Why would they stop working in this merge?

[ignazio-bovo]

In the channelclaim-* fixtures there where Council budget checks. They where concurrent to the budget update logic run at each new block, that's why they where failing. Budget checks would have been nice, but implementing them is time consuming.

I would have assumed these were working before. Why would they stop working in this merge?

  public async execute(): Promise<void> {
    this.expectedClaims = await getExpectedClaims(this.api, this.claimChannelRewardParams)
    const expectedClaimsSum = this.expectedClaims.reduce((sum, claim) => sum.add(new BN(claim)), new BN(0))
    const councilBudgetPre = await this.api.query.council.budget()
    await super.execute()
    const councilBudgetPost = await this.api.query.council.budget()
    assert.equal(councilBudgetPre.toString(), councilBudgetPost.add(expectedClaimsSum).toString())
  }

The execute function reads the council budget before and post execution. However there are multiple budget modifications due to the council budget bookkeeping logic (screenshot below). So the assertion checking only for the channel reward variation fails.

I am investigating why this error has not appeared before,
Edit: the execution block for the claim_channel_reward changes at each test run. So it is possible that previous tests were fortuitous
Edit2: I can confirm that these assertions fails on ephesus @ 2676a17 at the moment

[mnaamani]

Ok thanks for investigating that, it would be good to have such assertions as part of these fixtures but it is out of scope of this PR.