Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Upgrade to Storybook 7 #4406

Merged
merged 5 commits into from
Jun 5, 2023
Merged

⬆️ Upgrade to Storybook 7 #4406

merged 5 commits into from
Jun 5, 2023

Conversation

thesan
Copy link
Member

@thesan thesan commented Jun 2, 2023 •
edited
Loading

Note
node >= 16 is now required to run Storybook

@vercel
Copy link

vercel bot commented Jun 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Jun 5, 2023 9:30am
pioneer-2 ✅ Ready (Inspect) Visit Preview Jun 5, 2023 9:30am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Jun 5, 2023 9:30am

@thesan thesan marked this pull request as draft June 2, 2023 12:08
@vercel vercel bot temporarily deployed to Preview – pioneer-2-storybook June 2, 2023 14:52 Inactive
@thesan thesan requested a review from chrlschwb June 2, 2023 16:41
@thesan thesan marked this pull request as ready for review June 2, 2023 16:42
traumschule
traumschule approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@traumschule traumschule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be added to the Changelog / release notes:

7.0 breaking changes
Dropped support for Node 15 and below
Storybook 7.0 requires Node 16 or above. If you are using an older version of Node, you will need to upgrade or keep using Storybook 6 in the meantime.
Storybook 7 migration guide

packages/markdown-editor/package.json
@@ -44,7 +44,7 @@
"ts-loader": "^9.2.6",
"ts-node": "^10.4.0",
"typescript": "4.4.3",
"webpack": "^5.64.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, was there are reason to downgrade webpack?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually webpack was upgraded:
image

It's just that there was initially duplicated versions of webpack after upgrading storybook. yarn dedupe would have taken care of that but IMO it's just as good to just force the major version of webpack (unless we realized later that some particular minor version breaks the build).

@thesan
Copy link
Member Author

thesan commented Jun 5, 2023

This needs to be added to the Changelog / release notes:

7.0 breaking changes
Dropped support for Node 15 and below
Storybook 7.0 requires Node 16 or above. If you are using an older version of Node, you will need to upgrade or keep using Storybook 6 in the meantime.
Storybook 7 migration guide

@traumschule nice catch I should remember to mention it in the release notes when this gets released.

At the same time I don't think engines.node should be updated yet because the version 16+ is only required to run Storybook which is more of a dev dependency and upgrading to engines.node means a breaking change. Therefore I will rather upgrade engines.node on the backend branch which will be the next major release.

@thesan thesan merged commit bdb8d67 into dev Jun 5, 2023
@thesan thesan deleted the feature/storybook7 branch June 5, 2023 10:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traumschule traumschule traumschule approved these changes

@chrlschwb chrlschwb Awaiting requested review from chrlschwb

Assignees
No one assigned
Labels
builders-wg-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thesan @traumschule @chrlschwb