Fix TableViewCell skeleton not being removed & automaticNumberOfRows …

…reference (#402) * Change TableView subviewsToSkeleton to all subviews * Fix reference to automaticNumberOfRows from pr #401
Juanpe · Jun 10, 2021 · e9ac3a5 · e9ac3a5
1 parent fb83a62
commit e9ac3a5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Sources/Collections/CollectionViews/SkeletonCollectionViewProtocols.swift b/Sources/Collections/CollectionViews/SkeletonCollectionViewProtocols.swift
@@ -17,7 +17,7 @@ public protocol SkeletonCollectionViewDataSource: UICollectionViewDataSource {
 
 public extension SkeletonCollectionViewDataSource {
     func collectionSkeletonView(_ skeletonView: UICollectionView, numberOfItemsInSection section: Int) -> Int {
-        return Self.automaticNumberOfRows
+        return SkeletonCollectionDataSource.automaticNumberOfRows
     }
 
     func collectionSkeletonView(_ skeletonView: UICollectionView,

diff --git a/Sources/Collections/TableViews/SkeletonTableViewProtocols.swift b/Sources/Collections/TableViews/SkeletonTableViewProtocols.swift
@@ -16,7 +16,7 @@ public protocol SkeletonTableViewDataSource: UITableViewDataSource {
 
 public extension SkeletonTableViewDataSource {
     func collectionSkeletonView(_ skeletonView: UITableView, numberOfRowsInSection section: Int) -> Int {
-        return Self.automaticNumberOfRows
+        return SkeletonCollectionDataSource.automaticNumberOfRows
     }
 
     func numSections(in collectionSkeletonView: UITableView) -> Int { return 1 }

diff --git a/Sources/SubviewsSkeletonables.swift b/Sources/SubviewsSkeletonables.swift
@@ -18,7 +18,7 @@ extension UITableView {
 		// Some developer trying to call `view.showAnimatedSkeleton()`
 		// when the request or data is loading which sometimes happens before the ViewDidAppear
 		guard window != nil else { return [] }
-		return visibleCells + visibleSectionHeaders + visibleSectionFooters
+        return subviews
     }
 }