Fix TableViewCell skeleton not being removed & automaticNumberOfRows reference #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For UITableView the skeleton is added/removed to
visibleCells
,visibleSectionHeaders
&visibleSectionFooters
, however whenhideSkeleton
is called withreloadDataAfter: true
this can leave some cells with the skeleton still active becausevisibleCells
may not contain the same number of cells as whenshowSkeleton
was called (i.e. when the estimatedRowHeight is significantly less than the actual row height). Changed to add/remove skeleton to all TableView subviews. Fixes The skeleton view do not complete hide. #399.Fix
automaticNumberOfRows
reference error from PR Add SkeletonCollectionDataSource.automaticNumberOfRows Constant #401.Requirements (place an
x
in each of the[ ]
)