Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TableViewCell skeleton not being removed & automaticNumberOfRows reference #402

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

harrisonsj
Copy link
Contributor

Summary

  • For UITableView the skeleton is added/removed to visibleCells, visibleSectionHeaders & visibleSectionFooters, however when hideSkeleton is called with reloadDataAfter: true this can leave some cells with the skeleton still active because visibleCells may not contain the same number of cells as when showSkeleton was called (i.e. when the estimatedRowHeight is significantly less than the actual row height). Changed to add/remove skeleton to all TableView subviews. Fixes The skeleton view do not complete hide. #399.

  • Fix automaticNumberOfRows reference error from PR Add SkeletonCollectionDataSource.automaticNumberOfRows Constant #401.

Requirements (place an x in each of the [ ])

@Juanpe Juanpe self-requested a review June 10, 2021 16:58
@Juanpe
Copy link
Owner

Juanpe commented Jun 10, 2021

Hi @harrisonsj,

I've checked the code and LGTM :)

It'll be merged

@Juanpe Juanpe merged commit e9ac3a5 into Juanpe:main Jun 10, 2021
@Juanpe Juanpe mentioned this pull request Aug 13, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The skeleton view do not complete hide.
2 participants