Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hide skeleton layers on TableViewHeaderFooterView #260

Closed
darkside999 opened this issue Feb 19, 2020 · 1 comment · Fixed by #261
Closed

Don't hide skeleton layers on TableViewHeaderFooterView #260

darkside999 opened this issue Feb 19, 2020 · 1 comment · Fixed by #261
Labels
🐞 bug ✅ fixed

Comments

@darkside999
Copy link
Contributor

What did you do?

I showed skeleton view on table view with custom header section view

What did you expect to happen?

Header section view didn't hide itself skeleton layer

What happened instead?

Header section view continue showing skeleton layer

Steps to reproduce the behavior

  • create custom header section view
  • show skeleton view with this section on table view
  • hide skeleton view

SkeletonView Environment

SkeletonView version: 1.8.5
Xcode version: 11.2.1
Swift version: 5
@darkside999 darkside999 mentioned this issue Feb 19, 2020
Merged
@darkside999
Copy link
Contributor Author

Fixes #261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug ✅ fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes removing skeleton layers from table header footer sections darkside999/SkeletonView
2 participants
@Juanpe @darkside999