Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes removing skeleton layers from table header footer sections #261

Merged
merged 3 commits into from
Feb 20, 2020

Conversation

darkside999
Copy link
Contributor

Fixes #260

@darkside999 darkside999 changed the title Fixes removing skeleton layers from table header footer sections Juanpe/SkeletonView#260 Fixes removing skeleton layers from table header footer sections Feb 19, 2020
@Juanpe Juanpe changed the base branch from develop to master February 19, 2020 12:12
@Juanpe Juanpe changed the base branch from master to develop February 19, 2020 12:12
@Juanpe
Copy link
Owner

Juanpe commented Feb 20, 2020

Hi @darkside999, thanks for the contribution. I've checked the code, and it looks good :)

Just one thing to merge this PR, could you update the CHANGELOG file, please?

You only need to add this PR to the "Next version" section. You can use this template:

* [** {{Pull request Id}} **]({{Pull request URL}}): {{Pull request title}} - [@{{username of PR author}}](link of the profile of PR author)

@darkside999
Copy link
Contributor Author

@Juanpe done :)

@Juanpe
Copy link
Owner

Juanpe commented Feb 20, 2020

Thanks! it will be available in the next version 🎉

@Juanpe Juanpe merged commit fd7ce73 into Juanpe:develop Feb 20, 2020
@kidS2ran
Copy link

@Juanpe hi, i want to hide Header, footer view, how can i do it

@mieng18
Copy link

mieng18 commented Apr 15, 2022

@Juanpe I have the same problem with @kidS2ran when tried to do skeletonView with custom Header and custom collectionView . How can we hide it when we do SkeletonView

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't hide skeleton layers on TableViewHeaderFooterView
4 participants