Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HideSkeleton() does not apply transition within a UITableView #469

Open
4 tasks
PlayDevelop opened this issue Dec 8, 2021 · 4 comments
Open
4 tasks

HideSkeleton() does not apply transition within a UITableView #469

PlayDevelop opened this issue Dec 8, 2021 · 4 comments
Assignees

Comments

@PlayDevelop
Copy link

Description

The transition is broken when doing HideSkeleton(transition: .crossDisolve(TIME)) when the views is within a UITableView.

Same thing in Example app.

What type of issue is this? (place an x in one of the [ ])

  • [ X ] bug
  • enhancement (feature request)
  • question
  • documentation related
  • discussion

Requirements (place an x in each of the [ ])

  • [ X ] I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • [X ] I've read and agree to the Code of Conduct.
  • [X ] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

SkeletonView Environment:

SkeletonView version: 1.26.0
Xcode version: 13.1
Swift version: 5.5.1

Steps to reproduce:

Please replace this with the steps to reproduce the behavior.

  1. Apply Skeleton views within UITableView cell
  2. Show Skeleton with crossdisolve of 1 sec
  3. Hide Skeleton with crossdisolve of 1 sec

Expected result:

Skeleton shows and hide with expected transition time

Actual result:

Skeleton shows with crossdisolve time of 1, and hide with no transition

Attachments:

Logs, screenshots, sample project, funny gif, etc.

@Juanpe Juanpe added the 🐞 bug label Jan 7, 2022
@Juanpe Juanpe self-assigned this Jan 7, 2022
@Juanpe
Copy link
Owner

Juanpe commented Jan 7, 2022

Hi @PlayDevelop 👋🏼

You're right, I'm going to add it to the backlog to fix it asap 👍🏼

Thanks

@Juanpe Juanpe added the triaged label Jan 7, 2022
@shipinev
Copy link

Hey @Juanpe. First of all, thank you for this easy-to-use library. Do you have any update on the issue fix?

@Juanpe
Copy link
Owner

Juanpe commented Jan 17, 2022

Thanks, @shipinev. Not yet, sorry :/

@JacksonJang
Copy link
Contributor

I fixed!
Please check this solution.
#484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants