Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HideSkeleton() does not apply transition within a UITableView #469 #484

Closed
wants to merge 2 commits into from

Conversation

JacksonJang
Copy link
Contributor

Summary

Describe the goal of this PR. Mention any related Issue numbers.
issue Number : #469

Requirements (place an x in each of the [ ])

@JacksonJang
Copy link
Contributor Author

JacksonJang commented Jan 19, 2022

I found the problem and solved but I don't know why working..?
anyway, I think that the issue exist from "dataSource" and "reloadData()".
It's hard for me to solve the problem. if you need to help, I can help you continuously!!

[UITableView+CollectionSkeleton.swift]

func removeDummyDataSource(reloadAfter: Bool) {
        /*
        guard let dataSource = self.dataSource as? SkeletonCollectionDataSource else { return }
        restoreRowHeight()
        self.skeletonDataSource = nil
        self.dataSource = dataSource.originalTableViewDataSource
        */
        if let delegate = self.delegate as? SkeletonCollectionDelegate {
            self.skeletonDelegate = nil
            self.delegate = delegate.originalTableViewDelegate
        }

        //if reloadAfter { self.reloadData() }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant