-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type coercion to task constructors #109
Comments
Okay, no objections. Any volunteers? Some familiarity with Tables.jl interface and CategoricalArrays is required. Lets break this up into two separate PR's with two items each:
Some technical details:
|
In #114 I implemented the coercion methods as suggested, however the method |
Done. |
Branching off from #68:
In the current design one of the functions of task constructors is to establish the scientific type of the data. This is currently inferred from the data passed to the constructors, according to the convention that object
x
has scientific typescitype(x)
; see the docs for details.At present, this information is simply inferred from the data passed to the constructor. I suggest the following straightforward enhancement: The user passes, as an optional kwarg, a dictionary explaining how they would like to overide this behaviour. The dictionary is keyed on the names of feature and target columns; the values are the intended scitypes. So, a call might look like this:
After coercion, the constructor would print out the final post-coercion types and scitypes of all variables.
I can provide more detail on the existing design to potential implementers.
Any objections, other ideas?
The text was updated successfully, but these errors were encountered: