Add MLJ.{un,}supervisedtask methods #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition:
* fix output type of `coerce(types, X)`
* do not convert `AbstractVector{<:Integer}` to `Vector{Int}`
* add more tests
* check if a vector already has the requested scitype in the discrete case
giordano
force-pushed
the
type-coercion-tasks
branch
from
f13e0c1
to
3766394
Compare
|
This looks good. Can we call |
|
@giordano Sorry, I just pushed these small changes directly from my local branch to finish this off today. Many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address second part of #109. This is based on #114. No tests yet.