Skip to content

Commit

Permalink
Merge pull request #32 from JuliaAI/24-improve-show-for-logger-instances
Browse files Browse the repository at this point in the history
Extending Base.show to pretty print logger instances
  • Loading branch information
pebeto committed Jan 4, 2024
2 parents e907324 + 30de2d5 commit 38dd901
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/MLJFlow.jl
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ using MLFlowClient: MLFlow, logparam, logmetric,
createrun, MLFlowRun, updaterun,
healthcheck, logartifact, getorcreateexperiment

import Base: show
import MLJBase: save, log_evaluation

include("types.jl")
Expand Down
8 changes: 8 additions & 0 deletions src/types.jl
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,11 @@ function Logger(baseuri; experiment_name="MLJ experiment",
end
Logger(service, verbosity, experiment_name, artifact_location)
end
function show(io::IO, logger::MLJFlow.Logger)
print(io,
"MLFLowLogger(\"$(logger.service.baseuri)\",\n" *
" experiment_name=\"$(logger.experiment_name)\",\n" *
" artifact_location=\"$(logger.artifact_location)\",\n" *
") using MLFlow API version $(logger.service.apiversion)"
)
end
8 changes: 8 additions & 0 deletions test/types.jl
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,12 @@

@test typeof(logger) == MLJFlow.Logger
@test typeof(logger.service) == MLFlow

io = IOBuffer()
show(io, logger)
test_string = "MLFLowLogger(\"$(logger.service.baseuri)\",\n" *
" experiment_name=\"$(logger.experiment_name)\",\n" *
" artifact_location=\"$(logger.artifact_location)\",\n" *
") using MLFlow API version $(logger.service.apiversion)"
@test String(take!(io)) == test_string
end

0 comments on commit 38dd901

Please sign in to comment.