Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending Base.show to pretty print logger instances #32

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Extending Base.show to pretty print logger instances #32

merged 1 commit into from
Jan 4, 2024

Conversation

pebeto
Copy link
Member

@pebeto pebeto commented Dec 31, 2023

#24

@pebeto pebeto linked an issue Dec 31, 2023 that may be closed by this pull request
Improve show for logger instances #24
Closed
@pebeto pebeto requested a review from ablaom December 31, 2023 16:29
@pebeto pebeto self-assigned this Dec 31, 2023
@pebeto pebeto added the enhancement New feature or request label Dec 31, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 31, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e907324) 97.77% compared to head (30de2d5) 97.87%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev      #32      +/-   ##
==========================================
+ Coverage   97.77%   97.87%   +0.09%     
==========================================
  Files           4        4              
  Lines          45       47       +2     
==========================================
+ Hits           44       46       +2     
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ablaom
ablaom approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go, thanks!

@ablaom
Copy link
Member

ablaom commented Jan 4, 2024

Thanks @pebeto for your patience with the review.

@pebeto pebeto merged commit 38dd901 into dev Jan 4, 2024
4 checks passed
@pebeto pebeto deleted the 24-improve-show-for-logger-instances branch January 4, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ablaom ablaom ablaom approved these changes

Assignees

@pebeto pebeto

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve show for logger instances
2 participants
@pebeto @ablaom