-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UnivariateTimeTypeToContinuous transformer to builtins #245
Closed
Closed
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
84b1faa
Add minimal implementation of univariate case
a848050
Remove unnecessary type parameter
8881832
Merge branch 'venuur-add-timetype-continuous' into dev
3bcd534
Add type compatibility checks and clean! method
5ab3257
Merge branch 'dev' of https://github.com/alan-turing-institute/MLJMod…
bee3945
Merge branch 'venuur-add-timetype-continuous' into dev
6e01391
Fix typo in throw
3abaa09
Merge branch 'venuur-add-timetype-continuous' into dev
ae99b26
Add basic test and export statement
6744cc5
Merge branch 'dev' of https://github.com/alan-turing-institute/MLJMod…
f441e77
Add tests and fix default constructor
9655add
Merge branch 'dev' of https://github.com/alan-turing-institute/MLJMod…
775baaf
Merge branch 'venuur-add-timetype-continuous' into dev
3895228
Add missing backticks
a7da598
Merge branch 'venuur-add-timetype-continuous' into dev
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: I suggest "Convert a
Date
,DateTime
, andTime
vector to prevent confusion with multi-variate case.