-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UnivariateTimeTypeToContinous - take II #295
Conversation
…els.jl into venuur-add-timetype-continuous
Fix default constructor case of Hour(24) when applied to a Date vector. Hour cannot be added to Date objects, so the step must be converted to Day, but because this is a change to the step hyper parameter it must be adjusted. Unfortunately, this case cannot be distinguished from a user supplied date, so a warning must be shown, which is non-ideal for a common default case. Alternatively we can add an extra internal variable to track whether a user supplied step is given and only warn on that case, but that is extra complexity I am avoiding for this commit.
The fail is due to package conflict. This request should resolve it: |
@venuur In the tests on Julia 1.4 that run okay, there are some warnings being issued for the transformer. Be good if you can confirm they are to be expected and then I will silence them with https://travis-ci.com/github/alan-turing-institute/MLJModels.jl/jobs/371957210 |
Yes, the warnings are intentional. They’re the result of various data consistency checks and corrections.
|
Re-opening to retrigger CI |
We can ignore the branch fail here b/s PR test pass and the fail is due to test pkg conflict which is resolved on the base of PR. |
continuation of #245