Add UnivariateTimeTypeToContinous - take II #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…els.jl into venuur-add-timetype-continuous
Fix default constructor case of Hour(24) when applied to a Date vector. Hour cannot be added to Date objects, so the step must be converted to Day, but because this is a change to the step hyper parameter it must be adjusted. Unfortunately, this case cannot be distinguished from a user supplied date, so a warning must be shown, which is non-ideal for a common default case. Alternatively we can add an extra internal variable to track whether a user supplied step is given and only warn on that case, but that is extra complexity I am avoiding for this commit.
|
The fail is due to package conflict. This request should resolve it: |
|
@venuur In the tests on Julia 1.4 that run okay, there are some warnings being issued for the transformer. Be good if you can confirm they are to be expected and then I will silence them with https://travis-ci.com/github/alan-turing-institute/MLJModels.jl/jobs/371957210 |
|
Yes, the warnings are intentional. They’re the result of various data consistency checks and corrections.
|
|
Re-opening to retrigger CI |
|
We can ignore the branch fail here b/s PR test pass and the fail is due to test pkg conflict which is resolved on the base of PR. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #245