Fix degree with noncommutative variables

JuliaAlgebra · Oct 28, 2020 · 2b20331 · 2b20331
1 parent 45e69b8
commit 2b20331
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/src/monomial.jl b/src/monomial.jl
@@ -75,12 +75,14 @@ degree(v::AbstractVariable, var::AbstractVariable) = (v == var ? 1 : 0)
 #degree(m::AbstractMonomial, v::AbstractVariable) = _deg(v, powers(t)...)
 
 function degree(m::AbstractMonomial, v::AbstractVariable)
-    i = findfirst(isequal(v), variables(m))
-    if i === nothing || iszero(i)
-        0
-    else
-        exponents(m)[i]
+    deg = 0
+    # With Noncommutative variables, there may be several powers with the same variable
+    for (var, exp) in powers(m)
+        if var == v
+            deg += exp
+        end
     end
+    return deg
 end
 
 """

diff --git a/test/ncmonomial.jl b/test/ncmonomial.jl
@@ -24,6 +24,13 @@
             @test collect(exponents(Y)) == [2]
         end
     end
+    @testset "Issue #148" begin
+        @ncpolyvar x y z
+        m = x * y^4 * x^2
+        @test 3 == @inferred degree(m, x)
+        @test 4 == @inferred degree(m, y)
+        @test 0 == @inferred degree(m, z)
+    end
     @testset "Issue #71 of DynamicPolynomials" begin
         Mod.@ncpolyvar x y
         @test x^0 * y == y * x^0