Fix differentiate of AbstractArrays #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `differentiate([x+y,y+z],[x,y,z])` would return a 3 x 2 matrix instead of the more commonly used 2 x 3 matrix.
saschatimme
force-pushed
the
st/fix-jacobian
branch
from
627e5b3
to
7a7702a
Compare
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=========================================
- Coverage 92.17% 90.7% -1.48%
=========================================
Files 17 18 +1
Lines 588 624 +36
=========================================
+ Hits 542 566 +24
- Misses 46 58 +12
Continue to review full report at Codecov.
|
|
Could you mention it in the documentation and add your example ? |
|
I somehow forgot about this 😅 I added some docs. Since this is technically breaking, I think we need to bump the version to |
blegat
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
differentiate([x+y,y+z],[x,y,z])would return a 3 x 2matrix instead of the more commonly used 2 x 3 matrix.