Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix similar for Tuple #51

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix similar for Tuple #51

merged 2 commits into from
Jul 2, 2024

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 20, 2024

When we do a * b and a is uses Tuple as container, we should switch to Vector so that it can be mutated. similar isn't defined for Tuple anyway so this is currently a MethodError

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.93%. Comparing base (c01cd3f) to head (941cfca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   85.85%   85.93%   +0.08%     
==========================================
  Files          14       14              
  Lines         693      697       +4     
==========================================
+ Hits          595      599       +4     
  Misses         98       98              
Flag Coverage Δ
unittests 85.93% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blegat blegat merged commit f9ff304 into main Jul 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant