Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Grid Line Animations #38

Open
TheCedarPrince opened this issue Aug 4, 2020 · 6 comments · May be fixed by #422
Open

Improving Grid Line Animations #38

TheCedarPrince opened this issue Aug 4, 2020 · 6 comments · May be fixed by #422
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Low Priority Will be worked on but not of immediate concern.

Comments

@TheCedarPrince
Copy link
Member

Background

As we are finishing up the Grid lines initial PR, we are already thinking about how to improve it! This is somewhat lower priority currently but will be worked on consistently.

Additional Information

Here were some thoughts @Wikunia and I were thinking about implementing next:

  • Have a lighter grid (setline(0.5) or something) and bigger lines every 5 or so steps.
  • Have numbers and titles for the axis
  • The thing about extensibility using Val for example (see [WIP] Grid Lines Animation #18)

I also thought of a couple that I was exploring:

  • Arrows at the end of lines
  • Defining x and y axis limits for zero-lines

If anyone else has any thoughts, feel free to drop a comment/thought! For reference, here is what the current grid lines animation look like:

grid_animation

@TheCedarPrince TheCedarPrince added enhancement New feature or request good first issue Good for newcomers labels Aug 4, 2020
@TheCedarPrince TheCedarPrince self-assigned this Aug 4, 2020
@TheCedarPrince TheCedarPrince added the Low Priority Will be worked on but not of immediate concern. label Aug 4, 2020
@Wikunia Wikunia added this to the v0.2.0 milestone Aug 5, 2020
@Wikunia
Copy link
Member

Wikunia commented Aug 6, 2020

When you're working on this also make sure to change the test cases slightly to have better coverage.
i.e you currently test 4 animations but all use the same line_gap and line_thickness.

It might also be valuable to set the color maybe even two such that every second line is using a different color.

@Wikunia
Copy link
Member

Wikunia commented Aug 16, 2020

Maybe we should use SubAction appear for this as currently I feel like there is no way to actually have a drawn grid which does not disappear after it's drawn completely.

@TheCedarPrince
Copy link
Member Author

That makes sense to me @Wikunia.

Furthermore, the animation here does not actually "mean" anything. What I mean by that is that I can't draw vectors or objects in relation to the grid. I'd like to change that - see #98

@TheCedarPrince TheCedarPrince removed this from the v0.2.0 milestone Aug 30, 2020
@TheCedarPrince
Copy link
Member Author

See Ole's comment here in issue 97.

@Wikunia Wikunia added this to the v0.2.x milestone Sep 12, 2020
@TheCedarPrince TheCedarPrince added error-handling Everything related to error and warnings thrown at the user and removed error-handling Everything related to error and warnings thrown at the user labels Oct 26, 2020
@TheCedarPrince TheCedarPrince removed this from the v0.3.x milestone Oct 26, 2020
@muhammadalics
Copy link

Hi! Is this project still up for grabs?

@TheCedarPrince
Copy link
Member Author

Hey @muhammadalics - I have received your email. Let's discuss there. :)

@Wikunia Wikunia linked a pull request Sep 18, 2021 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Low Priority Will be worked on but not of immediate concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants