Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation persist after completion #97

Closed
TheCedarPrince opened this issue Aug 17, 2020 · 3 comments
Closed

Animation persist after completion #97

TheCedarPrince opened this issue Aug 17, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@TheCedarPrince
Copy link
Member

TheCedarPrince commented Aug 17, 2020

Is your feature request related to a problem? Please explain.

I was experimenting with BackgroundAction syntax and I was thinking it might be a good idea to extend SubAction syntax to BackgroundAction's. Especially for the functions draw_grid and zero_lines.

If that is the case, it might make sense to have BackgroundAction only have access to functions like draw_grid and zero_lines and not as a general Action.

Describe the solution you'd like

What I would love to see as a user interface would be something like this:

              BackgroundAction(1:180, ground), subactions = [
                 SubAction(1:60, draw_grid()),                                                    
                 SubAction(1:60, zero_lines())
                 ]

Also, I am not sure if this should be a separate issue, but I would like to see the grid lines persist after their initial animation such that I could draw on top of them later.

Describe alternatives you've considered

Currently, this would be the way to invoke this functionality:

               BackgroundAction(1:180, ground),                                        
               Action(1:60, draw_grid()),                                                    
               Action(1:60, zero_lines()),
@TheCedarPrince TheCedarPrince added the enhancement New feature or request label Aug 17, 2020
@Wikunia
Copy link
Member

Wikunia commented Aug 18, 2020

Yeah in the latter case the lines would not be persistent.
I was actually thinking about having something like

 BackgroundAction(1:180, ground),      
Action(1:180, draw_grid; subactions=[
    SubAction(1:60, appear(:lr, :tb))
])

where appear can take some arguments like here :lr left -> right and :tb for top -> bottom and then this gets saved in the parent Action options or something such that the draw_grid function knows how to handle that :D
Then Action(1:60, draw_grid) might simply draw the grid for that many frames without any animation?

@Wikunia Wikunia added this to the v0.2.0 milestone Aug 18, 2020
@Wikunia Wikunia changed the title Extend BackgroundAction with SubAction syntax Animation persist after completion Aug 18, 2020
@Wikunia
Copy link
Member

Wikunia commented Aug 18, 2020

Also see #100

@Wikunia
Copy link
Member

Wikunia commented Sep 7, 2020

I think I would handle this inside the draw grid one #38 and move this out of this milestone? What do you think about it @TheCedarPrince ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants