Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for Grid Animation #39

Closed
wants to merge 28 commits into from
Closed

Improvements for Grid Animation #39

wants to merge 28 commits into from

Conversation

TheCedarPrince
Copy link
Member

Initial draft implementations of ideas found in #38.

Wikunia and others added 28 commits July 21, 2020 23:28
@Wikunia
example version of a simple animating move
6274b2c
@Wikunia
different way of defining an animation
fef518a
@Wikunia
some small changes and test case
4f59066
@Wikunia
create folder test/images
128b27a
@Wikunia
don't test ffmpeg :D
5bd3a55
@Wikunia
point to line projection
fd6b8f3
@Wikunia
testing only 1.4 might change later
284f413
@Wikunia
bugfix interpolation + test
1f93b67
@TheCedarPrince
Minimal working example of drawing a line
1e661f8
@TheCedarPrince
Failed attempt at using javis for drawing gridlines
a112523
@TheCedarPrince
Created hacky method for creation of line gif
5363628
@TheCedarPrince
Fixing error for gridlines animation
2790002
@TheCedarPrince
Added temporary try-catch for array field error
396f15f
@TheCedarPrince
Grid animation can render one line
915cc07
@TheCedarPrince
Beginning to functionalize grid line creation
d11b931
@TheCedarPrince
Finished example of creating an animated grid with javis
f05d150
@TheCedarPrince
Added fix for checking if an object is a Transformation
be34e1c
@TheCedarPrince
Added choices for directions of grid lines and zero line creation
54d06fb
@TheCedarPrince
Successfully integrated kwargs into grid animations
c44f72b
@Wikunia
Merge branch 'master' into tcp-feature-2
f89bb9d
@TheCedarPrince
Added exports for draw_grid and zero_lines
e3dd772
@TheCedarPrince
Added support for drawing background animations
f9c8102
@TheCedarPrince
Removed proof of concept grid animation
840c688
@TheCedarPrince
Added test cases for zero line and grid animations
8a08fcf
@TheCedarPrince
Fixed exports and arrangement of file inclusions
59d17f8
@TheCedarPrince
Documentation fixes, optimizations, and syntax clarification
61329a0
@TheCedarPrince
Reference image for grid drawing test
80a0375
@TheCedarPrince
Reference image for zero line test
f90087f
@TheCedarPrince TheCedarPrince added enhancement New feature or request Low Priority Will be worked on but not of immediate concern. labels Aug 4, 2020
@TheCedarPrince TheCedarPrince self-assigned this Aug 4, 2020
@Wikunia
Copy link
Member

Wikunia commented Aug 4, 2020

Do you mind closing this for now until #18 is finished?
Currently this is super confusing to have 2PR with the same thing and this one will never be merged before the other.

@TheCedarPrince
Copy link
Member Author

Definitely agree @Wikunia . Closing now. Will reopen again in the future.

@TheCedarPrince TheCedarPrince mentioned this pull request Aug 5, 2020
Merged
@Wikunia Wikunia deleted the tcp-feature-38 branch September 17, 2020 07:39
@Wikunia Wikunia mentioned this pull request Dec 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TheCedarPrince TheCedarPrince

Labels
enhancement New feature or request Low Priority Will be worked on but not of immediate concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheCedarPrince @Wikunia