Wik feature setopacity #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.3 #241 +/- ##
==========================================
+ Coverage 96.91% 96.92% +0.01%
==========================================
Files 19 19
Lines 712 715 +3
==========================================
+ Hits 690 693 +3
Misses 22 22
Continue to review full report at Codecov.
|
TheCedarPrince
requested changes
Oct 23, 2020
src/action_animations.jl
Outdated
Comment on lines
299
to
301
| 0.0 | ||
| 0.3 | ||
| 0.7, |
There was a problem hiding this comment.
These are missing commas in the matrix.
TheCedarPrince
added a commit
that referenced
this pull request
Nov 10, 2020
* first step of Action -> Object, SubAction -> Action (#226) * first step of Action -> Object, SubAction -> Action * docstring for Action * docstrings for Object * Implementation of render and act (#228) * use act and render syntax * Working with the variable instead of the id (#230) * working without extra identifier * Tutorial 1 v0.3 (#244) * tutorial 1 for v0.3 * Updated tutorial 1 explanation Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * Docstrings v0.3 (#237) * first step of Action -> Object, SubAction -> Action * fixed unit tests * fixed svg tests * fix animations.jl (only morphing is missing) * changed morphing. All tests should pass * codecov and ambiguity * docstring for Action * small docstring fixes * removed ability to have more transitions in one action * docstrings for Object * docstring for BackgroundObject * copy action when adding to an object * use act and render syntax * working without extra identifier * extra codecov test * updated tutorial 1 * some docstring fixes for v0.3 * Final check on first pass of v0.3.0 docstrings Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * Ability to disable an action after its last defined frame (#242) * keep or not keep an action * Wik feature setopacity (#241) * implementation of setopacity * Translation -> anim_translate and co + unit tests (#250) * Translation -> anim_translate and co + unit tests * Change BackgroundObject to Background (#261) * sed and replaced all occurences of BackgroundObject to Background * Notice about syntax change for background * Added notice about change of Action syntax * Formatted docstring for Background * Tutorial 1 for v0.3 (#262) * updated tutorial to `anim_rotate_around` Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * Feature global frames (#265) * bugfix in :same for Action and implementation of Glob * Rel -> RFrames, Glob to GFrames * Example follow path v0.3 (#264) * follow bezier path for v0.3 with GFrames * preprocess_frames! function (#263) * preprocess_frames! function Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * Tutorial 6 for v0.3 (#267) * tutorial 6 for v0.3 * Adjusted some grammar and light rewording of some sentences Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * HowTo v0.3 (#269) * first part of HowTo Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * Updated Jarvis (#272) * Updated Jarvis with draw_text Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * LaTeX tutorial for v0.3 (#271) * updated Latex tutorial Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * [WIP] Feature transpose (#175) - morphing several shapes - i.e. transpose Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * Warning if no background (#273) * show a warning if some frames don't have a background * Update Tutorial 2 for v0.3.0 (#268) * Reduxed code for tutorial 2 * Changed notes from Action to Object syntax * Cleaned code and fixed up grammar * Fixed wording * Fixed code * Fixed references to Object * Removed superfluous file * Removed section on Animation * v0.3 Fourier (#274) * fourier example * Docstrings for v0.3 (#276) * docstrings fixes for anim_, act!, javis, SubAction, grammar Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * Warning if action is defined out of object frames (#278) * Throw warning if action is outside object frames * test case fix + format * Clarified warning msg Co-authored-by: Jacob Zelko <jacobszelko@gmail.com> * Redux of tutorial 5 (#280) * Redux of tutorial 5 Co-authored-by: Ole Kröger <o.kroeger@opensourc.es> * Final check v0.3 (#281) * Removed SubAction and checked for Rel/BackgroundAction * fixed all references * added line to changelog * finished v0.3 Co-authored-by: Ole Kröger <o.kroeger@opensourc.es> * format * Taming and link to change * changed SubAction name to Action * removed prints Co-authored-by: Jacob Zelko <jacobszelko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
For reviewers:
This is built on top of #237 so that should be reviewed first.
If you are contributing to
Javis.jl, please make sure you are able to check off each item on this list:CHANGELOG.mdwith whatever changes/features I added with this PR?Project.toml+ set an upper bound of the dependency (if applicable)?testdirectory (if applicable)?Link to relevant issue(s)
Closes #240
How did you address these issues with this PR? What methods did you use?
I've basically copied what existed for
sethue()and added a test case.