Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added :all Symbol to Javis #303

Merged
merged 9 commits into from
Mar 28, 2021
Merged

Added :all Symbol to Javis #303

merged 9 commits into from
Mar 28, 2021

Conversation

TheCedarPrince
Copy link
Member

@TheCedarPrince TheCedarPrince commented Dec 14, 2020

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #247

How did you address these issues with this PR? What methods did you use?

I added to the Frames.jl and Object.jl file code to allow for finding the maximum of a background frame. I did not add tests as I saw that we have not added tests for the :same keyword. Should we add testing? Does the logic make sense here for what I did?

@TheCedarPrince TheCedarPrince added the enhancement New feature or request label Dec 14, 2020
@TheCedarPrince TheCedarPrince removed the request for review from Wikunia December 15, 2020 03:16
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #303 (00961c7) into master (dca8210) will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   95.94%   96.33%   +0.39%     
==========================================
  Files          21       21              
  Lines        1012     1120     +108     
==========================================
+ Hits          971     1079     +108     
  Misses         41       41              
Impacted Files Coverage Δ
src/Javis.jl 97.54% <ø> (+0.14%) ⬆️
src/structs/Object.jl 100.00% <ø> (ø)
src/structs/Frames.jl 100.00% <100.00%> (ø)
src/backgrounds.jl 100.00% <0.00%> (ø)
src/structs/Video.jl 100.00% <0.00%> (ø)
src/structs/Action.jl 100.00% <0.00%> (ø)
src/action_animations.jl 100.00% <0.00%> (ø)
src/structs/ObjectSetting.jl 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca8210...00961c7. Read the comment docs.

Copy link
Member

@Wikunia Wikunia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing you might want to add and yes please add test cases. I think we actually have some for :same. Maybe not unit tests but we use it in some animations.

src/structs/Frames.jl Outdated Show resolved Hide resolved
@Wikunia
Copy link
Member

Wikunia commented Mar 13, 2021

You might wanna have a look @TheCedarPrince
Do you think this is ready for merging?

@Wikunia Wikunia self-requested a review March 13, 2021 12:21
@TheCedarPrince
Copy link
Member Author

Hey @Wikunia - I tested this out yesterday and all the tests passed on my end! I ran into the ImageIO issue (#315) similar to @flyaflya while testing so I will continue experimenting there. Otherwise, I approve this PR! Feels good to be getting in the groove again! 😉

@Wikunia Wikunia merged commit 4c7b31a into master Mar 28, 2021
@Wikunia Wikunia deleted the tcp-feature-all branch March 28, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make an :all Symbol for Frame Ranges
2 participants