Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting for weighted bases #96

Merged
merged 5 commits into from
May 24, 2021
Merged

Plotting for weighted bases #96

merged 5 commits into from
May 24, 2021

Conversation

TSGut
Copy link
Member

@TSGut TSGut commented May 24, 2021

See JuliaApproximation/MultivariateOrthogonalPolynomials.jl#73 (comment) and JuliaApproximation/MultivariateOrthogonalPolynomials.jl#73 (comment)

So I think this does actually just work as you said @dlfivefifty. At least testing it for weighted Zernike and weighted Jacobi gives the expected correct plots.

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #96 (fc2f50e) into master (f3e0d96) will increase coverage by 1.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   89.58%   90.77%   +1.18%     
==========================================
  Files           7        7              
  Lines         509      531      +22     
==========================================
+ Hits          456      482      +26     
+ Misses         53       49       -4     
Impacted Files Coverage Δ
src/plotting.jl 81.25% <100.00%> (+2.67%) ⬆️
src/ContinuumArrays.jl 86.20% <0.00%> (+0.49%) ⬆️
src/operators.jl 82.60% <0.00%> (+14.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e0d96...fc2f50e. Read the comment docs.

@dlfivefifty
Copy link
Member

Can you add tests? See

@testset "Plotting" begin

We probably want to add tests to the quick-and-dirty weighted Chebyshev defined above

@TSGut
Copy link
Member Author

TSGut commented May 24, 2021

Yes, will do.

@TSGut
Copy link
Member Author

TSGut commented May 24, 2021

This works for finite case and PaddedLayout infinite case. I'm not sure if there is an easy way to make this work for more generic infinite case of e.g. broadcast vectors as well but that doesn't seem supported for the unweighted bases either so that's probably fine for now.

@dlfivefifty
Copy link
Member

Can you bump the patch version so I can merge and tag?

@TSGut
Copy link
Member Author

TSGut commented May 24, 2021

I guess 0.7.5 is ok? done.

@dlfivefifty dlfivefifty merged commit eab5d3c into JuliaApproximation:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants