Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define method for colorview instead of converting to Matrix{<:Color} #12

Merged
merged 1 commit into from Apr 6, 2019

Conversation

@giordano
Copy link
Member

giordano commented Apr 6, 2019

Fix #11.

@giordano giordano force-pushed the giordano:colorview branch from 925cce8 to 790c3b7 Apr 6, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 6, 2019

Pull Request Test Coverage Report for Build 45

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.7%) to 94.444%

Totals Coverage Status
Change from base Build 20: 8.7%
Covered Lines: 17
Relevant Lines: 18

💛 - Coveralls
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 6, 2019

Codecov Report

Merging #12 into master will increase coverage by 8.63%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12      +/-   ##
=======================================
+ Coverage   86.36%   95%   +8.63%     
=======================================
  Files           3     3              
  Lines          22    20       -2     
=======================================
  Hits           19    19              
+ Misses          3     1       -2
Impacted Files Coverage Δ
src/AstroImages.jl 100% <100%> (+5.88%) ⬆️
src/plot-recipes.jl 100% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 282b59e...790c3b7. Read the comment docs.

@giordano giordano merged commit d6e921f into JuliaAstro:master Apr 6, 2019
5 checks passed
5 checks passed
codecov/patch 100% of diff hit (target 86.36%)
Details
codecov/project 95% (+8.63%) compared to 282b59e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+8.7%) to 94.444%
Details
@giordano giordano deleted the giordano:colorview branch Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.