-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccd2rgb function #15
ccd2rgb function #15
Conversation
aquatiko
commented
Jun 19, 2019
•
edited
Loading
edited
- Function
- Docs
- Test
Tests are passing locally. |
@giordano Here I'm returning a RGB image at the end, I can also add a keyword argument enabling user to specify his choice of colour scheme. Should I add it? Or user can do the same thing by himself upon the function returning the RGB image. |
Merge only after #19 |
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 99.08% 99.18% +0.09%
==========================================
Files 3 4 +1
Lines 109 122 +13
==========================================
+ Hits 108 121 +13
Misses 1 1
Continue to review full report at Codecov.
|
@giordano Can this be merged now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, replace the check_diff
function with isapprox
and then we're probably good to go
Needs a CI-rerun after JuliaAstro/Reproject.jl#6 gets merged and a stable release of Reproject have been made. |
Tests are failing (failing build of WebIO on AppVeyor is completely unrelated, doesn't affect tests of this package) |
Tests were failing because there was a need to change files upstream after JuliaAstro/Reproject.jl#6. I have made the necessary changes. |
Remember to set the minimum required version of Reproject.jl to 0.3.0 in the Project.toml file |
@giordano this PR is done from my side. |