Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccd2rgb function #15

Merged
merged 16 commits into from
Aug 8, 2019
Merged

ccd2rgb function #15

merged 16 commits into from
Aug 8, 2019

Conversation

aquatiko
Copy link
Member

@aquatiko aquatiko commented Jun 19, 2019

  • Function
  • Docs
  • Test

@aquatiko aquatiko changed the title ccd2rgb function [WIP]ccd2rgb function Jun 19, 2019
@aquatiko aquatiko changed the title [WIP]ccd2rgb function ccd2rgb function Jun 22, 2019
@aquatiko
Copy link
Member Author

Tests are passing locally.
Need to add dependency of reproject for this to go green here.

@aquatiko
Copy link
Member Author

aquatiko commented Jun 22, 2019

@giordano Here I'm returning a RGB image at the end, I can also add a keyword argument enabling user to specify his choice of colour scheme. Should I add it? Or user can do the same thing by himself upon the function returning the RGB image.

@aquatiko
Copy link
Member Author

aquatiko commented Jul 1, 2019

Merge only after #19

src/ccd2rgb.jl Outdated Show resolved Hide resolved
src/ccd2rgb.jl Outdated Show resolved Hide resolved
src/ccd2rgb.jl Outdated Show resolved Hide resolved
src/ccd2rgb.jl Outdated Show resolved Hide resolved
src/ccd2rgb.jl Outdated Show resolved Hide resolved
src/ccd2rgb.jl Outdated Show resolved Hide resolved
test/ccd2rgb.jl Outdated Show resolved Hide resolved
test/ccd2rgb.jl Outdated Show resolved Hide resolved
test/ccd2rgb.jl Outdated Show resolved Hide resolved
test/ccd2rgb.jl Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #15 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   99.08%   99.18%   +0.09%     
==========================================
  Files           3        4       +1     
  Lines         109      122      +13     
==========================================
+ Hits          108      121      +13     
  Misses          1        1
Impacted Files Coverage Δ
src/AstroImages.jl 100% <ø> (ø) ⬆️
src/ccd2rgb.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d38397...6f07e49. Read the comment docs.

@aquatiko
Copy link
Member Author

@giordano Can this be merged now?

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, replace the check_diff function with isapprox and then we're probably good to go

test/ccd2rgb.jl Outdated Show resolved Hide resolved
test/ccd2rgb.jl Outdated Show resolved Hide resolved
@aquatiko
Copy link
Member Author

Needs a CI-rerun after JuliaAstro/Reproject.jl#6 gets merged and a stable release of Reproject have been made.

@giordano
Copy link
Member

giordano commented Aug 3, 2019

Tests are failing (failing build of WebIO on AppVeyor is completely unrelated, doesn't affect tests of this package)

@aquatiko aquatiko changed the title ccd2rgb function [WIP]ccd2rgb function Aug 7, 2019
@aquatiko
Copy link
Member Author

aquatiko commented Aug 7, 2019

Tests are failing (failing build of WebIO on AppVeyor is completely unrelated, doesn't affect tests of this package)

Tests were failing because there was a need to change files upstream after JuliaAstro/Reproject.jl#6. I have made the necessary changes.

@giordano
Copy link
Member

giordano commented Aug 7, 2019

Remember to set the minimum required version of Reproject.jl to 0.3.0 in the Project.toml file

@aquatiko aquatiko changed the title [WIP]ccd2rgb function ccd2rgb function Aug 8, 2019
@aquatiko
Copy link
Member Author

aquatiko commented Aug 8, 2019

@giordano this PR is done from my side.

@giordano giordano merged commit 9a3483d into JuliaAstro:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants