Interpolator tweak #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquatiko
force-pushed
the
map_coord_tweak
branch
from
1b96b53
to
0f3da24
Compare
3 tasks
giordano
requested changes
Jul 28, 2019
src/utils.jl
Outdated
| Pads a given array and creates a border with edge elements. | ||
| """ | ||
| function pad_edges(array_in::Matrix{T}) where {T} | ||
| image = zeros(size(array_in)[1] + 2, size(array_in)[2] + 2) |
There was a problem hiding this comment.
You're not using the type T. I'm pretty sure that for type-stability you really want to allocate a matrix with eltype T
test/core.jl
Outdated
| @test check_diff(reproject(imgin, imgout, order = 2)[1], rp.reproject_interp(hdu2, hdu1.header, order = 2)[1]) == true | ||
| @test check_diff(reproject(imgin[1], imgout[1], shape_out = (1000,1000))[1], | ||
| rp.reproject_interp(hdu2, astropy.wcs.WCS(hdu1.header), shape_out = (1000,1000))[1]) == true | ||
| @test isapprox(reproject(imgin, imgout, order = 0)[1]', rp.reproject_interp(hdu2, hdu1.header, order = 0)[1], nans = true, atol = 1e-4) |
There was a problem hiding this comment.
I prefer using relative tolerance, rtol, rather than absolute tolerance. The latter doesn't say anything about the significance of the difference
aquatiko
force-pushed
the
map_coord_tweak
branch
from
90ea212
to
9a4437e
Compare
giordano
reviewed
Jul 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a tweak as done and mentioned here.