ported taiutc #39
Merged
ported taiutc #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 206
💛 - Coveralls |
helgee
reviewed
Jun 19, 2018
test/runtests.jl
Outdated
| @@ -180,7 +180,7 @@ AstroTime.update() | |||
| leap = UTCEpoch(2016, 12, 31, 23, 59, 60) | |||
| tai1, tai2 = ERFA.utctai(julian1(leap), julian2(leap)) | |||
| @test Epochs.utctai(julian1(leap), julian2(leap)) == ERFA.utctai(julian1(leap), julian2(leap)) | |||
| @test_broken Epochs.taiutc(tai1, tai2) == ERFA.taiutc(tai1, tai2) | |||
| @test Epochs.taiutc(tai1, tai2) == ERFA.taiutc(tai1, tai2) | |||
There was a problem hiding this comment.
Since the strict equality test is failing on 32bits again I would propose to move all ported function tests to approximate equality.
There was a problem hiding this comment.
all means all the test till now or only this?
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 88.53% 88.78% +0.25%
==========================================
Files 7 7
Lines 436 446 +10
==========================================
+ Hits 386 396 +10
Misses 50 50
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17