Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported UTC<->TAI is incorrect during leap second #17

Closed
helgee opened this issue Apr 4, 2018 · 2 comments · Fixed by #39
Closed

Ported UTC<->TAI is incorrect during leap second #17

helgee opened this issue Apr 4, 2018 · 2 comments · Fixed by #39

Comments

@helgee
Copy link
Member

helgee commented Apr 4, 2018

The ports of taiutc and utctai are too simplistic and give an incorrect result during a leap second, see https://github.com/liberfa/erfa/blob/master/src/utctai.c, https://github.com/liberfa/erfa/blob/master/src/taiutc.c.

I have rolled the changes back and added two broken tests that should pass once the issue is fixed: https://github.com/JuliaAstro/AstronomicalTime.jl/blob/master/test/runtests.jl#L181
@helgee
Copy link
Member Author

helgee commented Apr 4, 2018

CC: @ashishpriyadarshiCIC

@ashishpriyadarshiCIC
Copy link
Contributor

Ok @helgee .I'll start working on it

This was referenced Jun 14, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ported taiutc prakharcode/AstroTime.jl
2 participants
@helgee @ashishpriyadarshiCIC