Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added F04 model #31

Merged
merged 9 commits into from
Jul 17, 2020
Merged

Added F04 model #31

merged 9 commits into from
Jul 17, 2020

Conversation

icweaver
Copy link
Member

@icweaver icweaver commented Jul 14, 2020

@icweaver icweaver mentioned this pull request Jul 14, 2020
2 tasks
@mileslucas mileslucas mentioned this pull request Jul 14, 2020
10 tasks
@icweaver icweaver changed the title added F04 model Added F04 model Jul 14, 2020
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #31 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   99.45%   99.48%   +0.03%     
==========================================
  Files           4        4              
  Lines         182      195      +13     
==========================================
+ Hits          181      194      +13     
  Misses          1        1              
Impacted Files Coverage Δ
src/DustExtinction.jl 100.00% <ø> (ø)
src/color_laws.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f719...7a73ae8. Read the comment docs.

@giordano
Copy link
Member

so the above is just my workaround to make F04 compatible in all versions.

Could you please leave a comment in the code so that when we'll drop support for Julia v1.0 we can remove this workaround?

@icweaver
Copy link
Member Author

Sure, just added! 1f6fae8

haha, it's kind of wild to think about leaving 1.0 behind some day ='(

@giordano
Copy link
Member

haha, it's kind of wild to think about leaving 1.0 behind some day ='(

Not really, there is the general hope of making Julia v1.6 the new Long Term Support version (but the decision will be taken after its release), at which point Julia v1.0 will not be supported anymore 😉

Copy link
Member

@mileslucas mileslucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if you bump version to 0.9.0, too we can release.

@icweaver icweaver mentioned this pull request Jul 16, 2020
@mileslucas mileslucas merged commit 2308bec into JuliaAstro:master Jul 17, 2020
@icweaver icweaver deleted the F04 branch August 27, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants