-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable travis and coveralls #17
Conversation
The travis build is failing. Looks like the shared library is not being created in the build. I tried to reproduce this locally by removing the built library and running Is there a way to force the build without uninstalling my system libcfitsio? Would it be advisable to always build from source in FITSIO.jl to ensure that everyone has the same libcfitsio? |
Strange, seems like the shared lib should exist: https://travis-ci.org/JuliaAstro/FITSIO.jl/jobs/40326257#L422 |
(that last link should have highlighted line 422, but i guess that doesn't work) |
I tried running the travis script in an ubuntu1404 vm, and it worked. Don't understand why this is failing. |
I was able to reproduce this, or something like it, once I uninstalled my system libcfitsio. After doing
Then
I don't fully understand what BinDeps is doing when it generates the I'm on Ubuntu 14.04. |
I should also note that I'm on Julia 0.3.2 and BinDeps 0.3.6. |
What's in |
That looks good:
|
I'm also on julia 0.3.2 and BinDeps 0.3.6. |
What's |
Stupid github buttons. |
My guess is that BinDeps is getting confused because of |
That would be it... I had |
The shared lib is definitely there in the travis build: https://travis-ci.org/JuliaAstro/FITSIO.jl/jobs/40511657 (see L453) But the |
Stab in the dark --- a/deps/build.jl
+++ b/deps/build.jl
@@ -7,6 +7,7 @@ url = "ftp://heasarc.gsfc.nasa.gov/software/fitsio/c/cfitsio$version.tar.gz"
libcfitsio = library_dependency("libcfitsio")
provides(Sources, URI(url), libcfitsio, unpacked_dir="cfitsio")
depsdir = BinDeps.depsdir(libcfitsio)
+pwddir = pwd()
srcdir = joinpath(depsdir, "src", "cfitsio")
prefix = joinpath(depsdir, "usr")
@unix_only libfilename = "libcfitsio.so"
@@ -21,6 +22,7 @@ provides(BuildProcess,
`./configure --prefix=$prefix`
`make shared install`
end)
+ ChangeDirectory(pwddir)
end
end),
libcfitsio) |
Hmmm... should we ask some BinDeps experts? Or just give up and install libcfitsio via apt-get on Travis? |
Let's just use the apt package. |
Changes Unknown when pulling f37d5cb on kbarbary:add-travis into * on JuliaAstro:master*. |
Note that I just corrected an error in a badge URL directly on master. |
I just enabled travis and coveralls on the respective websites.
This adds the .travis.yml file and badges to the README.