Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in L from Monday 26/11/18 #5

Merged
merged 23 commits into from
Nov 29, 2018
Merged

Work in L from Monday 26/11/18 #5

merged 23 commits into from
Nov 29, 2018

Conversation

Adriaenvc
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 26, 2018

Pull Request Test Coverage Report for Build 122

  • 42 of 57 (73.68%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 81.897%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/d.jl 4 6 66.67%
src/r.jl 3 5 60.0%
src/l.jl 35 46 76.09%
Totals Coverage Status
Change from base Build 115: -0.9%
Covered Lines: 475
Relevant Lines: 580

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #5 into master will decrease coverage by 0.89%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #5     +/-   ##
=========================================
- Coverage   82.79%   81.89%   -0.9%     
=========================================
  Files          23       25      +2     
  Lines         523      580     +57     
=========================================
+ Hits          433      475     +42     
- Misses         90      105     +15
Impacted Files Coverage Δ
src/r.jl 81.81% <60%> (-18.19%) ⬇️
src/d.jl 66.66% <66.66%> (ø)
src/l.jl 76.08% <76.08%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a97f8c...c18942b. Read the comment docs.

Copy link
Member

@helgee helgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Please have a look at my comments.

src/l.jl Outdated Show resolved Hide resolved
src/l.jl Outdated Show resolved Hide resolved
src/l.jl Outdated Show resolved Hide resolved
src/l.jl Outdated Show resolved Hide resolved
test/f.jl Outdated Show resolved Hide resolved
test/l.jl Outdated Show resolved Hide resolved
src/d.jl Outdated Show resolved Hide resolved
test/l.jl Outdated Show resolved Hide resolved
@helgee helgee merged commit b9d41f7 into JuliaAstro:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants