Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving English fonts in SenseHat.jl #18

Merged
merged 3 commits into from
Jan 21, 2020
Merged

Conversation

NandVinchhi
Copy link
Contributor

No description provided.

@aviks
Copy link
Member

aviks commented Jan 13, 2020

Can you do a before and after image of the improvements? For some of the characters at least. You can take photos with your phone and upload.

@NandVinchhi
Copy link
Contributor Author

I actually do not have access to a sensehat. Could I plot on computer and send screenshot?

@aviks
Copy link
Member

aviks commented Jan 14, 2020

sure

@NandVinchhi
Copy link
Contributor Author

This is examples of a few characters that I edited.
left - before
right - after
Screenshot (32)

@aviks
Copy link
Member

aviks commented Jan 14, 2020

I like the capitals, but the small letters seem to have become too small. I don't think the small letters look worse. Can you revert them? Or may be scale them up.

@NandVinchhi
Copy link
Contributor Author

ok

@NandVinchhi
Copy link
Contributor Author

done.

@aviks aviks merged commit b03c6ee into JuliaBerry:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants