Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add building and testing of PGO+LTO LLVM and Julia #345

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Add building and testing of PGO+LTO LLVM and Julia #345

wants to merge 56 commits into from
+43 −0

Commits on Sep 9, 2024

  1. Add building and testing of PGO+LTO LLVM and Julia

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7723d66 View commit details
    Browse the repository at this point in the history

  2. Fix run pgo_script command

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1b3e706 View commit details
    Browse the repository at this point in the history

  3. Make pgo script a bit quicker 

    Now takes ~10 minutes.
Precompiling OrdinaryDiffEq takes 367s and Plots 135s. Actually running the script takes 1-2 minutes.
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    add640c View commit details
    Browse the repository at this point in the history

  4. Fix lto build directory 

    Not really sure why this works, but it seems to.
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e0fcd80 View commit details
    Browse the repository at this point in the history

  5. Fix upload name for lto binary

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4fafdc1 View commit details
    Browse the repository at this point in the history

  6. Use profile from building julia for PGO 

    I think 0f8bae0 might have slowed down the binary. At least locally this seems to be roughly the same as using pgo_script prior to 0f8bae0.

I have 7 binaries locally and cannot work out why some are slower than others but I think this should be good enough.
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8dec66b View commit details
    Browse the repository at this point in the history

  7. Replace + with - character in .arches file 

    Buildkite was complaining about non-alphanumeric character
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    04bc679 View commit details
    Browse the repository at this point in the history

  8. Add -m64 as a flag to clang 

    Hopefully this fixes the error as I have no idea how to debug this
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4a944cd View commit details
    Browse the repository at this point in the history

  9. Print patchelf config log if make fails

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c24698b View commit details
    Browse the repository at this point in the history

  10. Fix typo

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    cc7a072 View commit details
    Browse the repository at this point in the history

  11. Try finding correct gcc - taken from CLANGSA_CXXFLAGS in julia Makefile

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    657bdf7 View commit details
    Browse the repository at this point in the history

  12. Specify gcc version exactly

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f907ba9 View commit details
    Browse the repository at this point in the history

  13. Try different path

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    682b02e View commit details
    Browse the repository at this point in the history

  14. Try different path + pass into flags used for building not just config

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    657b390 View commit details
    Browse the repository at this point in the history

  15. Specify CFLAGS and CXXFLAGS properly

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3c409ba View commit details
    Browse the repository at this point in the history

  16. Remove hardcoded gcc install dir

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f7fcaf1 View commit details
    Browse the repository at this point in the history

  17. Upload profile data so builds can be reproduced

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    aaf61c7 View commit details
    Browse the repository at this point in the history

  18. Switch rootfs image to llvm_passes 

    This seems to be what the form source builds use, though they seem to have been failing for the last year. Not sure if I still need to specify `--gcc-install-dir`.
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3a22736 View commit details
    Browse the repository at this point in the history

  19. Add back gcc install dir for sanitize opts 

    This gets passed to patch elf's configure step
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0b7d70e View commit details
    Browse the repository at this point in the history

  20. Add back gc install dir everywhere

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    45c520c View commit details
    Browse the repository at this point in the history

  21. Update rootfs_hash 

    I don't think ROOTFS_IMAGE_NAME actually does anything on its own
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7e2256b View commit details
    Browse the repository at this point in the history

  22. Stop clang throwing error on unused function in crc32 

    Not sure why gcc doesn't.
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    2fe728a View commit details
    Browse the repository at this point in the history

  23. Fix

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    75e32b8 View commit details
    Browse the repository at this point in the history

  24. Revert "Fix" 

    This reverts commit c2ebde3.
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1d142de View commit details
    Browse the repository at this point in the history

  25. Revert "Stop clang throwing error on unused function in crc32" 

    This reverts commit a5d1274.
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    83c8607 View commit details
    Browse the repository at this point in the history

  26. Remove -Werror till JuliaLang/julia#53897 merges

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    07fa39e View commit details
    Browse the repository at this point in the history

  27. Clean up 

    GCCFLAG should no longer be required now that we use the llvmpasses image
    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3703bd8 View commit details
    Browse the repository at this point in the history

  28. Try to fix downloading pgo binary when testing

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    60baf58 View commit details
    Browse the repository at this point in the history

  29. Add comment

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4f1c0c8 View commit details
    Browse the repository at this point in the history

  30. Tabs to spaces

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    13d9447 View commit details
    Browse the repository at this point in the history

  31. Copy cleanup from JuliaCI@ba182b0

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c669dba View commit details
    Browse the repository at this point in the history

  32. Workaround parser disliking +

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0408a2f View commit details
    Browse the repository at this point in the history

  33. Fix triplet extraction

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    eda42b7 View commit details
    Browse the repository at this point in the history

  34. Include make flags from .arches for stage 1

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5f6fe68 View commit details
    Browse the repository at this point in the history

  35. Hack in LDFLAGS

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    2d1ba85 View commit details
    Browse the repository at this point in the history

  36. Be more targeted with LDFLAGS

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    81196b0 View commit details
    Browse the repository at this point in the history

  37. Try to prevent binary-dist from rebuilding sysimg.ji

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    62cebaf View commit details
    Browse the repository at this point in the history

  38. Try again

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    eaabb50 View commit details
    Browse the repository at this point in the history

  39. Try again

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    05efb04 View commit details
    Browse the repository at this point in the history

  40. Try again

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    df41626 View commit details
    Browse the repository at this point in the history

  41. Try again

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    63b21a3 View commit details
    Browse the repository at this point in the history

  42. Try again

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    214bb07 View commit details
    Browse the repository at this point in the history

  43. Test fix

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0de5f46 View commit details
    Browse the repository at this point in the history

  44. Try again

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4b7099c View commit details
    Browse the repository at this point in the history

  45. Fix again

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    aa3e34c View commit details
    Browse the repository at this point in the history

  46. Retrigger

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ea9a02f View commit details
    Browse the repository at this point in the history

  47. Try again

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    482f04a View commit details
    Browse the repository at this point in the history

  48. Try again

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d165dc5 View commit details
    Browse the repository at this point in the history

  49. Fix again

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6595ba2 View commit details
    Browse the repository at this point in the history

  50. Fix up

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8dc52bd View commit details
    Browse the repository at this point in the history

  51. Rebuild

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b4a1a2f View commit details
    Browse the repository at this point in the history

  52. Switch back to official Julia Repo

    @Zentrik
    Zentrik committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    faa645d View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Try fix for lld not being installed into usr/tools

    @Zentrik
    Zentrik committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a6d823d View commit details
    Browse the repository at this point in the history

  2. Hopefully correct fix

    @Zentrik
    Zentrik committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a51739b View commit details
    Browse the repository at this point in the history

  3. Retrigger

    @Zentrik
    Zentrik committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    173d95e View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Switch back to Julia repo

    @Zentrik
    Zentrik committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    399ae7e View commit details
    Browse the repository at this point in the history