-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - Dimension handling #137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 88.94% 88.61% -0.34%
==========================================
Files 11 12 +1
Lines 1475 1519 +44
==========================================
+ Hits 1312 1346 +34
- Misses 163 173 +10
Continue to review full report at Codecov.
|
ok, I think this is good to go. Now, detection is done by using |
Just noticed it needs some love for 4D fields |
Decided to merge this PR as soon as possible due to some operational needs. |
This is a WIP for handling dimension in a more general way.
The idea is to first try to identify X, Y, Z and T dimensions using the
axis
attribute when present (optional in CF files). If not, the fallback is on the standard_namelongitude
,latitude
andtime
(which is required in CF files).Then, we should probably add units detection, etc.
I'll also add detection on
long_names
but this seems to be optional just likeaxis
in CF files.This is pretty rough right now, but it works with all my test files (CMIP, CORDEX and ERAINT files).